You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/14 01:45:41 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #14390: [BEAM-2085] Add capability to declare resource hints in pipeline transforms.

tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r612881171



##########
File path: sdks/python/apache_beam/transforms/resources.py
##########
@@ -38,11 +39,26 @@ def _parse_int(value):
   return str(value).encode('ascii')
 
 
+def _return_max(v1, v2):

Review comment:
       Agreed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org