You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/06 03:18:27 UTC
[GitHub] sijie commented on a change in pull request #817: Client times out requests in batch rather than individually
sijie commented on a change in pull request #817: Client times out requests in batch rather than individually
URL: https://github.com/apache/bookkeeper/pull/817#discussion_r155137222
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -182,6 +184,19 @@ public Integer getSample() {
}
});
initializeExplicitLacFlushPolicy();
+
+ if (bk.getConf().getAddEntryQuorumTimeout() > 0) {
+ SafeRunnable monitor = new SafeRunnable() {
Review comment:
I think if you use this [SafeRunnable](https://github.com/apache/bookkeeper/blob/master/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/SafeRunnable.java), you can use lambda here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services