You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/11/28 09:59:31 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4120: [Improvement][API] ignore noNodeException when get worker groups
codecov-io commented on pull request #4120:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4120#issuecomment-735209106
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=h1) Report
> Merging [#4120](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=desc) (8fd2605) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/bb13f2eae78e4b829816068e8ca3d337d97a0fd2?el=desc) (bb13f2e) will **decrease** coverage by `0.01%`.
> The diff coverage is `59.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4120 +/- ##
============================================
- Coverage 39.85% 39.84% -0.02%
+ Complexity 3013 3010 -3
============================================
Files 467 467
Lines 22136 22146 +10
Branches 2714 2716 +2
============================================
Hits 8823 8823
- Misses 12499 12509 +10
Partials 814 814
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `79.03% <59.09%> (-3.67%)` | `8.00 <4.00> (ø)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `56.09% <0.00%> (-4.88%)` | `6.00% <0.00%> (-1.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.00% <0.00%> (-2.78%)` | `9.00% <0.00%> (-2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=footer). Last update [bb13f2e...8fd2605](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4120?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org