You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2007/05/23 09:04:20 UTC
[jira] Created: (HARMONY-3934) [drlvm] DRLVM should report error
message for incorrect parameters
[drlvm] DRLVM should report error message for incorrect parameters
------------------------------------------------------------------
Key: HARMONY-3934
URL: https://issues.apache.org/jira/browse/HARMONY-3934
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Vladimir Ivanov
DRLVM should report error message for incorrect parameters instead of crash.
For example, run of cunit tests as:
build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
leads to the debug window on WinXP (attached) while
build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3934:
--------------------------------------
Attachment: H3934.patch
Ok, based on dev-list discussion results (no objection) I'm renaming vm.dlls properties to gc.dll one.
(http://mail-archives.apache.org/mod_mbox/harmony-dev/200706.mbox/%3c587698b80706270633n7fb7e54m6c05cbb41f062107@mail.gmail.com%3e)
The attached patch does the following things:
1. reports error if -XX propery format is broken (-XX:+key, -XX:-key or -XX:key=[value] is allowed), i.e. '-XX:gc.dll=' is a proper specification (of empty value) while '-XX:gc.dll' argument produces error ('initialize_properties' returnns the status code now).
2. renamed 'vm.dlls' to 'gc.dll'". This required to do the following:
2.1 add a check that "gc.dll" property is always set (the vm_init code expects this property is set either to default value or it is set through command line)
2.2 remove "parsing cycle" of gc.dll (previously "vm.dlls" may contain the list of DLLs)
I've tested DRLVM with different variants of related command line - works as expected.
Please get the patch committed.
Thanks
Vladimir Beliaev
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: H3934.patch, screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3934) [drlvm] DRLVM should report error
message for incorrect parameters
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Ivanov updated HARMONY-3934:
-------------------------------------
Attachment: screenshot-1.jpg
> [drlvm] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3934:
---------------------------------------
Summary: [drlvm][init] DRLVM should report error message for incorrect parameters (was: [drlvm] DRLVM should report error message for incorrect parameters)
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507835 ]
Vladimir Ivanov commented on HARMONY-3934:
------------------------------------------
OK, I just want to mention that this issue is reproduced for me on:
svn = r550321, (Jun 25 2007), Windows/ia32/msvc 1310, debug build
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507215 ]
Vladimir Beliaev commented on HARMONY-3934:
-------------------------------------------
Vladimir, please provide the buggy command line you are saying about (w/o build.bat wrappers)...
Say the current DRLVM "wrong argument processing" does not crash for me:
./deploy/jdk/jre/bin/java -showversion -XX:vm.dlls=gc_cc.dll XXX
...
svn = r549650, (Jun 22 2007), Windows/ia32/msvc 1310, release build
...
Uncaught exception in main:
java.lang.NoClassDefFoundError: XXX
./deploy/jdk/jre/bin/java -XX:vm.dlls=gc_cc1.dll XXX
Loading error The specified module could not be found.
Mandatory library cannot be loaded: gc_cc1.dll
HMYEXEL062E Internal VM error: Failed to create Java VM
FAILED to invoke JVM
Thanks
Vladimir
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507415 ]
Vladimir Beliaev commented on HARMONY-3934:
-------------------------------------------
Ok, to get the command line one can use '-d' argument which is passed to 'ant' by build.bat like:
build.bat -d cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
As result the detecteed "buggy" command line is:
./deploy/jdk/jre/bin/java -XX:vm.dlls Foo
(i.e. the right option would be -XX:vm.dlls=gc_gen.dll)
I'll take a look at this bug...
Thanks
Vladimir Beliaev
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3934) [drlvm][init] DRLVM should report
error message for incorrect parameters
Posted by "Xiao-Feng Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao-Feng Li closed HARMONY-3934.
---------------------------------
Resolution: Fixed
Committed. Thanks.
> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
> Key: HARMONY-3934
> URL: https://issues.apache.org/jira/browse/HARMONY-3934
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Attachments: H3934.patch, screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
> build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
> build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.