You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/15 23:43:27 UTC
[GitHub] [pulsar] vcottagiri opened a new pull request #7548: Issue #5922 - Cleanup poms to use ${project.groupId} and ${project.version} consistently
vcottagiri opened a new pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #5922
### Motivation
As described in #5922
To make the poms consistent across the codebase
### Modifications
- Replaced <groupId>org.apache.pulsar</groupId> to <groupId>${project.groupId}</groupId> where applicable
- Replaced <version>2.7.0-SNAPSHOT</version> to <version>${project.version}</version>where applicable
- Replaced <version>${project.parent.version}</version> to <version>${project.version}</version> where applicable
- Removed <groupId>org.apache.pulsar</groupId> when redundant
### Verifying this change
- [X] Make sure that the change passes the CI checks.
- [X] This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vcottagiri commented on a change in pull request #7548: [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently
Posted by GitBox <gi...@apache.org>.
vcottagiri commented on a change in pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548#discussion_r455924931
##########
File path: examples/flink/pom.xml
##########
@@ -74,6 +72,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
Yes, my bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vcottagiri commented on a change in pull request #7548: [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently
Posted by GitBox <gi...@apache.org>.
vcottagiri commented on a change in pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548#discussion_r455897202
##########
File path: examples/flink/pom.xml
##########
@@ -74,6 +72,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
@merlimat
Sorry, this dependency is not needed as its inherited from the root pom.
I will create a PR fixing this asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7548: [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548#discussion_r455903098
##########
File path: examples/flink/pom.xml
##########
@@ -74,6 +72,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
Ok, the buildtools is anyway injected as a dependency for all the modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vcottagiri commented on a change in pull request #7548: [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently
Posted by GitBox <gi...@apache.org>.
vcottagiri commented on a change in pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548#discussion_r455932914
##########
File path: examples/flink/pom.xml
##########
@@ -74,6 +72,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
fixed by #7560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #7548: [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7548:
URL: https://github.com/apache/pulsar/pull/7548
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org