You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/07 02:28:27 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #3681: feat(config-ui): support typescript and format webpack-related files.
mintsweet opened a new pull request, #3681:
URL: https://github.com/apache/incubator-devlake/pull/3681
# Summary
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
support typescript and format webpack-related files.
### Does this close any open issues?
Prepare for the miller-columns component.
### Screenshots
Nothing.
### Other Information
Nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #3681: feat(config-ui): support typescript and format webpack-related files
Posted by GitBox <gi...@apache.org>.
likyh merged PR #3681:
URL: https://github.com/apache/incubator-devlake/pull/3681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on pull request #3681: feat(config-ui): support typescript and format webpack-related files
Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3681:
URL: https://github.com/apache/incubator-devlake/pull/3681#issuecomment-1305025554
Why was typescript introduced in devlake?
Currently, many props in our code have been passed through many layers, and we cannot quickly understand the content and function of these props in subsequent use. As a result, we need to spend a lot of time to understand the original position of props, if we use typescript, we can clearly understand the content and function of each props.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on pull request #3681: feat(config-ui): support typescript and format webpack-related files
Posted by GitBox <gi...@apache.org>.
likyh commented on PR #3681:
URL: https://github.com/apache/incubator-devlake/pull/3681#issuecomment-1305039595
I really agree with it [Laugh and Cry]. It's not good that no TS is used in the transmission. Some places use parameters that are not passed in, and some pass in variables not defined before. But would you like to inform everyone about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org