You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2010/06/18 23:01:27 UTC
[jira] Created: (ZOOKEEPER-789) Improve FLE log messages
Improve FLE log messages
------------------------
Key: ZOOKEEPER-789
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
Project: Zookeeper
Issue Type: Improvement
Reporter: Flavio Paiva Junqueira
Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Attachment: ZOOKEEPER-789.patch
It is a good suggestion. Uploading a new patch...
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885326#action_12885326 ]
Patrick Hunt commented on ZOOKEEPER-789:
----------------------------------------
+1, thanks flavio.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Assignee: Flavio Paiva Junqueira
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Status: Open (was: Patch Available)
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881337#action_12881337 ]
Hadoop QA commented on ZOOKEEPER-789:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12447713/ZOOKEEPER-789.patch
against trunk revision 953041.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/119/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/119/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/119/console
This message is automatically generated.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Attachment: ZOOKEEPER-789.patch
Thanks for pointing it out, Pat. I forgot to edit the preferences (new desktop). Here is a new patch.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883572#action_12883572 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-789:
--------------------------------------------------
There is no need for testing here. This is just a modification to log messages.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-789:
---------------------------------
Attachment: (was: ZOOKEEPER-789.patch)
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884611#action_12884611 ]
Hadoop QA commented on ZOOKEEPER-789:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448310/ZOOKEEPER-789.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/128/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/128/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/128/console
This message is automatically generated.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883499#action_12883499 ]
Ivan Kelly commented on ZOOKEEPER-789:
--------------------------------------
The patch attached passes each member of Notification separatedly to printNotification. Would it not be simpler to just pass the whole Notification object to printNotification. This way if the Notification object changes internally, only printNotification needs to be changed.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Status: Patch Available (was: Open)
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-789:
-----------------------------------
Status: Open (was: Patch Available)
Flavio can you resubmit with using tabs for indentation? (good to update your editor to only use spaces, eclipse?) Thanks.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Status: Patch Available (was: Open)
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-789:
-----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-789:
---------------------------------
Attachment: ZOOKEEPER-789.patch
Fixed up loggraph parsing, and changed printNotification to take the Notification object itself rather than all the little parts.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Status: Patch Available (was: Open)
Affects Version/s: 3.3.1
Fix Version/s: 3.3.2
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2
>
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883567#action_12883567 ]
Hadoop QA commented on ZOOKEEPER-789:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448310/ZOOKEEPER-789.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/console
This message is automatically generated.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-789:
-----------------------------------
Fix Version/s: 3.4.0
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-789:
---------------------------------------------
Attachment: ZOOKEEPER-789.patch
I have created a method to print info about a notification and placed the call to the method to right after the notification structure is created in FastLeaderElection.WorkerReceiver.run(). This way all received notifications are logged.
There is no test, since this is just a modification to message logging.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-789:
-----------------------------------
Attachment: ZOOKEEPER-789.patch
The patch still had tab issues. I cleaned it up using emacs to untabify the entire file (including the original patch changes, the cleanup tool cleans up both tabs and unnecessary whitespace issues). so this latest patch has only whitespace changes, not functional differences.
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885512#action_12885512 ]
Hudson commented on ZOOKEEPER-789:
----------------------------------
Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/])
ZOOKEEPER-789. Improve FLE log messages
> Improve FLE log messages
> ------------------------
>
> Key: ZOOKEEPER-789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.3.1
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch
>
>
> Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.