You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/10/01 11:26:05 UTC
[PR] Persist the match-anywhere search toggle in the URL [airflow]
pierrejeambrun opened a new pull request, #74019:
URL: https://github.com/apache/airflow/pull/74019
The substring ("match anywhere") search toggle only persisted in each browser's localStorage, so a filtered search could not be reproduced from a shared link — a colleague opening the URL saw prefix-only results unless they happened to have the same toggle enabled locally (#73772).
This mirrors the toggle in a shareable `match_anywhere` URL param. It is a repeated param listing the searchbars whose toggle is on (e.g. `?match_anywhere=dag_id&match_anywhere=run_id`), so pages with several independent text filters stay unambiguous. A key present in the URL wins so a shared link reproduces the sender's results; otherwise the existing per-searchbar localStorage preference still applies, and toggling the control writes both.
The change is a single central tweak to the `useAdvancedSearch` hook, so every searchbar and per-filter toggle that already uses it is covered uniformly.
- Dags search with match-anywhere off (default — no param):
- Dags search with match-anywhere on (`?match_anywhere=dags` in the address bar):
closes: #73772
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.8)
Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist the match-anywhere search toggle in the URL [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #74019:
URL: https://github.com/apache/airflow/pull/74019#issuecomment-5930578023
https://github.com/user-attachments/assets/3fd4b804-2a41-4da4-a959-6eda9aab4693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist the match-anywhere search toggle in the URL [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #74019:
URL: https://github.com/apache/airflow/pull/74019#issuecomment-5948895836
Updated, we are now capturing 'negative' for sharing urls.
> How is our source of truth chain supposed to work here and then with https://github.com/apache/airflow/pull/74021?
Resolution order is url -> localstorage -> global setting (added in the following PR).
> We only say when match anywhere is on. Do we also want an explicit match anywhere is off? Because otherwise we're going to localStorage or the user default.
Yes indeed. Addressed in last commit.
https://github.com/user-attachments/assets/39105648-fb92-449e-8e1f-93dddef9baf2
> If this is in url params, we should completely remove the localStorage option and only have global config + url param
Localstorage is still usefull when navigating from within the application (because all those internal redirection links won't be providing those query params in the url). Typically:
- Use the navbar to navigate to the 'dags' page. Activate the advanced search. (url is updated and sharable)
- Navigate away from this page
- Come back to the dag page by clicking on the 'nav bar'
- If we remove the local storage, this will fall back to the user 'default' while the person explicitely set the `match everywherre` for this particular filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist the match-anywhere search toggle in the URL [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #74019:
URL: https://github.com/apache/airflow/pull/74019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org