You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/02/19 02:09:15 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #14662: GH-31905: [DevTools] Add linting to Cython files

assignUser commented on code in PR #14662:
URL: https://github.com/apache/arrow/pull/14662#discussion_r1111136436


##########
.pre-commit-config.yaml:
##########
@@ -47,3 +47,8 @@ repos:
           - python
         exclude: vendored
         args: [--config, python/setup.cfg]
+  - repo: https://github.com/MarcoGorelli/cython-lint
+    rev: v0.12.4
+    hooks:
+      - id: cython-lint
+        args: [--max-line-length=120]

Review Comment:
   nit: flake8 uses 88 as line length, should this match or are the reasons to increase it for cython files?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org