You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2021/03/22 19:36:42 UTC
[Impala-ASF-CR] Update Python requests package to 2.20.0
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17215
Change subject: Update Python requests package to 2.20.0
......................................................................
Update Python requests package to 2.20.0
See https://2.python-requests.org/en/master/community/updates/#id8.
This is currently only used in the tests, but it's best to fix
this now.
Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
---
M infra/python/deps/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17215/1
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2:
(1 comment)
Seems like dependency fetching is prohibited by the --no-index flag:
https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/infra/python/bootstrap_virtualenv.py#L165-L169
It worked for me when I listed the all the packages and moved everything to stage2-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17215/2/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17215/2/infra/python/deps/requirements.txt@20
PS2, Line 20: # Remember, all modules below need to support python 2.6.
AFAIK we are dropping support for python 2.6 from Impala 4.0, so this constraint might not needed anymore.
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Mar 2021 12:27:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 12:53:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6992/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:36:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 28 Mar 2021 03:13:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17215/2/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17215/2/infra/python/deps/requirements.txt@20
PS2, Line 20: # Remember, all modules below need to support python 2.6.
> AFAIK we are dropping support for python 2.6 from Impala 4.0, so this const
Yes, after Impala 3.4.0 was released there were several proposals for Impala 4.0 that break compatibility in various areas; see https://lists.apache.org/thread.html/r19b95826b59486d61c1f8f5c1edd93adb8ec9925f66ff42c0c103d66%40%3Cdev.impala.apache.org%3E
Dropping support for Python 2.6 was one of these, so the above line can be removed, and Python changes requiring Python 2.7 are now OK.
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 23:20:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17215
to look at the new patch set (#3).
Change subject: Update Python requests package to 2.20.0
......................................................................
Update Python requests package to 2.20.0
See https://2.python-requests.org/en/master/community/updates/#id8.
This is currently only used in the tests, but it's best to fix
this now.
While here, remove now-false not about required support for Python
2.6.
Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
---
M infra/python/deps/requirements.txt
M infra/python/deps/stage2-requirements.txt
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17215/3
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7014/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Mar 2021 21:32:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6992/
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:46:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/8418/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:41:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2:
Hi, all! This failed with "Could not find a version that satisfies the requirement chardet<3.1.0,>=3.0.2". Do you know how to manage that? I can't recall how python deps are managed and what would be causing this if pypi clearly has 3.0.2 available:
https://pypi.org/project/chardet/3.0.2/
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:59:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2:
(Sorry, my message was only partly written. So:)
...It worked for me when I listed the all the packages and moved everything to stage2-requirements.txt:
requests == 2.20.0
chardet == 3.0.4
idna == 2.8
urllib3 == 1.21.1
certifi == 2020.12.5
Added Laszlo to the conversation because I think he knows the details better than me.
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Mar 2021 12:29:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8453/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Mar 2021 21:50:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:36:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Update Python requests package to 2.20.0
See https://2.python-requests.org/en/master/community/updates/#id8.
This is currently only used in the tests, but it's best to fix
this now.
While here, remove now-false not about required support for Python
2.6.
Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Reviewed-on: http://gerrit.cloudera.org:8080/17215
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M infra/python/deps/requirements.txt
M infra/python/deps/stage2-requirements.txt
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Zoltan Borok-Nagy: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] Update Python requests package to 2.20.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 )
Change subject: Update Python requests package to 2.20.0
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 01:19:18 +0000
Gerrit-HasComments: No