[GitHub] [pinot] richardstartin commented on pull request #10372: Let applyAnd to be applied using different window sizes

["richardstartin (via GitHub)" <gi...@apache.org>]

richardstartin commented on PR #10372:
URL: https://github.com/apache/pinot/pull/10372#issuecomment-1453095098

   I don't think I can review this because 
   * a performance improvement is reported, but not in Apache Pinot itself, so it's impossible to review based on the sources alone
   * no benchmarks to demonstrate improvement in the external component this change accelerates are provided with the change
   * benchmarks to quantify the degradation to users who aren't using the external component this change accelerates haven't been run (do they regress? Do they improve?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org