You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/10 03:35:06 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #186: Add Exist endpoints to all services

hanahmily commented on code in PR #186:
URL: https://github.com/apache/skywalking-banyandb/pull/186#discussion_r990894968


##########
api/proto/banyandb/database/v1/rpc.proto:
##########
@@ -233,6 +264,8 @@ service IndexRuleRegistryService {
       get:"/v1/index-rule/schema/lists/{group}"
     };
   };
+  // Exist doesn't expose an HTTP endpoint. Please use HEAD method to touch Get instead
+  rpc Exist(IndexRuleRegistryServiceExistRequest) returns (IndexRuleRegistryServiceExistResponse);

Review Comment:
   Elasticsearch's `Exist` function uses HTTP's `HEAD` method to query the server index path. If the code is 404, the return value is false. 200 returns true.
   
   Our new `Exist` services always return 200. If a client wants to use the `HEAD` method, it could touch the current `Get` services. They will work as Elasticsearch's behavior.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org