You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/08 00:32:25 UTC
[GitHub] [geode] Bill opened a new pull request #5353: GEODE-8337: Rename Version enum to KnownVersion; VersionOrdinal to Version
Bill opened a new pull request #5353:
URL: https://github.com/apache/geode/pull/5353
[GEODE-8337](https://issues.apache.org/jira/browse/GEODE-8337)
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on pull request #5353: GEODE-8337: Rename Version enum to KnownVersion; VersionOrdinal to Version
Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5353:
URL: https://github.com/apache/geode/pull/5353#issuecomment-655658035
I'm re-running DistributedTestOpenJDK11. It failed a client backward-compatibility test due to a log4j bug in Geode 1.8.0: https://issues.apache.org/jira/browse/GEODE-8345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill closed pull request #5353: GEODE-8337: Rename Version enum to KnownVersion; VersionOrdinal to Version
Posted by GitBox <gi...@apache.org>.
Bill closed pull request #5353:
URL: https://github.com/apache/geode/pull/5353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on pull request #5353: GEODE-8337: Rename Version enum to KnownVersion; VersionOrdinal to Version
Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5353:
URL: https://github.com/apache/geode/pull/5353#issuecomment-655796305
because git didn't notice the renaming: Version->KnownVersion, VersionOrdinal->Version as renaming, I'm closing this PR. Here's a better one where I explictly used `git mv` and separated the two renamings in two commits: https://github.com/apache/geode/pull/5355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org