You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "nseekhao (via GitHub)" <gi...@apache.org> on 2023/06/05 13:58:33 UTC
[GitHub] [arrow-datafusion] nseekhao opened a new issue, #6544: Substrait: Support for more flexible join condition expressions
nseekhao opened a new issue, #6544:
URL: https://github.com/apache/arrow-datafusion/issues/6544
### Is your feature request related to a problem or challenge?
If you run a roundtrip test on
```sql
SELECT d1.b, d2.c FROM data d1 JOIN data d2 ON CAST(d1.b AS int) = d2.e
```
you'll got the error `Error: Internal("invalid join condition expression")`.
This is due to the lack of support of expressions not in the form `AND(f0(...), ..., fk(...))`, where `fi()` is `EQ()` in the consumer ([ref](https://github.com/apache/arrow-datafusion/blob/main/datafusion/substrait/src/logical_plan/consumer.rs#LL367C5-L367C5)).
### Describe the solution you'd like
Support for more arbitrary join condition expressions.
### Describe alternatives you've considered
This effort can be incremental. I just wanted to make sure this gets brought up and tracked.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Substrait: Support for more flexible join condition expressions [arrow-datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia closed issue #6544: Substrait: Support for more flexible join condition expressions
URL: https://github.com/apache/arrow-datafusion/issues/6544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #6544: Substrait: Support for more flexible join condition expressions
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6544:
URL: https://github.com/apache/arrow-datafusion/issues/6544#issuecomment-1586337976
I wonder if https://github.com/apache/arrow-datafusion/pull/6135 fixes this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Substrait: Support for more flexible join condition expressions [arrow-datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on issue #6544:
URL: https://github.com/apache/arrow-datafusion/issues/6544#issuecomment-1807626554
The new roundtrip tests cover SQL in this issue (except the `CAST` part). Closing this ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] nseekhao commented on issue #6544: Substrait: Support for more flexible join condition expressions
Posted by "nseekhao (via GitHub)" <gi...@apache.org>.
nseekhao commented on issue #6544:
URL: https://github.com/apache/arrow-datafusion/issues/6544#issuecomment-1605076309
> I wonder if https://github.com/apache/arrow-datafusion/pull/6135 fixes this?
Hmmm I don't think so. Because of these [lines](https://github.com/apache/arrow-datafusion/pull/6135/files#diff-d1c5f4c37ac8286d2045acb61bee17382179469557132eb02844413b260ae41bR267-R269) in the producer:
``` rust
if join.filter.is_some() {
return Err(DataFusionError::NotImplemented("join filter".to_string()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org