You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 03:38:48 UTC

[GitHub] [pulsar] esadek opened a new pull request #11063: [docs] Capitalize cli menu item

esadek opened a new pull request #11063:
URL: https://github.com/apache/pulsar/pull/11063


   ### Motivation
   
   Improve documentation by fixing improperly capitalized acronym.
   
   ### Modifications
   
   Change menu item from "Cli" to "CLI".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #11063: [docs] Capitalize cli menu item

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11063:
URL: https://github.com/apache/pulsar/pull/11063


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11063: [docs] Capitalize cli menu item

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11063:
URL: https://github.com/apache/pulsar/pull/11063#discussion_r657607032



##########
File path: site2/website/static/js/custom.js
##########
@@ -110,7 +110,7 @@ window.addEventListener('load', function () {
     const cli = document.querySelector("a[href='#cli']").parentNode;
     const cliMenu =
         '<li>' +
-        '<a id="cli-menu" href="#">Cli <span style="font-size: 0.75em">&nbsp;▼</span></a>' +
+        '<a id="cli-menu" href="#">CLI <span style="font-size: 0.75em">&nbsp;▼</span></a>' +

Review comment:
       @tuteng does the case matter?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] tuteng commented on a change in pull request #11063: [docs] Capitalize cli menu item

Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #11063:
URL: https://github.com/apache/pulsar/pull/11063#discussion_r657761587



##########
File path: site2/website/static/js/custom.js
##########
@@ -110,7 +110,7 @@ window.addEventListener('load', function () {
     const cli = document.querySelector("a[href='#cli']").parentNode;
     const cliMenu =
         '<li>' +
-        '<a id="cli-menu" href="#">Cli <span style="font-size: 0.75em">&nbsp;▼</span></a>' +
+        '<a id="cli-menu" href="#">CLI <span style="font-size: 0.75em">&nbsp;▼</span></a>' +

Review comment:
       I think that ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org