You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2021/05/26 19:36:25 UTC
[GitHub] [mina-sshd] tomaswolf opened a new pull request #197: SSHD-1168, SSHD-1171, SSHD-1172: OpenSshCertificate fixes
tomaswolf opened a new pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197
Fixes:
- Comparing certificate timestamps as unsigned longs
- Test certificates without expiration date
- Checking for correct certificate types (user/host) being used in correct contexts (host key, user auth)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #197: SSHD-1168, SSHD-1171, SSHD-1172: OpenSshCertificate fixes
Posted by GitBox <gi...@apache.org>.
tomaswolf commented on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849853674
@alex-sherwin sorry about that. I had been thinking about Instant, too, but in the end I decided to just remove these two methods since I didn't need them. Converting to Instant would also have to take care of that unsigned long issue, and I didn't see a way to do that cleanly; best I could think of was to saturate the 64bit value at LONG_MAX. But if you have a clean solution I have nothing against using Instant at all.
If your change undoes some of what I did and solves it differently that's no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] alex-sherwin commented on pull request #197: SSHD-1168, SSHD-1171, SSHD-1172: OpenSshCertificate fixes
Posted by GitBox <gi...@apache.org>.
alex-sherwin commented on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849821398
I have a pending PR I was going to open tonight that touches some of this too, and in mine I changed the `OpenSshCertificate` valid before/after variables to `Instant` as it feels like a better developer experience to interact with (in my opinion).
I also found that there is some additional invalid encoding in the OpenSshCertificate code from the original PR that has gone unnoticed with the Critical Options/Extensions data.
My upcoming PR was to include code which can easily generate signed OpenSshCertificates, but ended up making the aforementioned fixes/changes as well (preview: https://github.com/alex-sherwin/mina-sshd2/pull/1)
@tomaswolf Would you prefer if I un-do my change of using `Instant` before submitting the final PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf merged pull request #197: SSHD-1168, SSHD-1171, SSHD-1172: OpenSshCertificate fixes
Posted by GitBox <gi...@apache.org>.
tomaswolf merged pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] alex-sherwin edited a comment on pull request #197: SSHD-1168, SSHD-1171, SSHD-1172: OpenSshCertificate fixes
Posted by GitBox <gi...@apache.org>.
alex-sherwin edited a comment on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849821398
I have a pending PR I was going to open tonight that touches some of this too, and in mine I changed the `OpenSshCertificate` valid before/after variables to `Instant` as it feels like a better developer experience to interact with (in my opinion).
I also found that there is some additional invalid encoding in the OpenSshCertificate code from the original certkeys PR that has gone unnoticed with the Critical Options/Extensions data.
My upcoming PR was to include code which can easily generate signed OpenSshCertificates, but ended up making the aforementioned fixes/changes as well (preview: https://github.com/alex-sherwin/mina-sshd2/pull/1)
@tomaswolf Would you prefer if I un-do my change of using `Instant` before submitting the final PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org