[GitHub] [airflow] potiuk commented on issue #16684: Helm Chart Allow for Empty data settings

[GitBox <gi...@apache.org>]

potiuk commented on issue #16684:
URL: https://github.com/apache/airflow/issues/16684#issuecomment-873404534


   How about simply using valueFrom option. Seems that you could pass name of the secret and key and set it as environment variable:
   
   ```
       env:
         - name: SECRET_USERNAME
           valueFrom:
             secretKeyRef:
               name: mysecret
               key: username
         - name: SECRET_PASSWORD
           valueFrom:
             secretKeyRef:
               name: mysecret
               key: password
   
   ```
   
   In the case from @mik-laj it would be:
   
   ```
   env:
     - name: AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD
       valueFrom:
          secretKeyRef:
              name: vault-secret-name
              key: databaseUrl
   ```
   
   Sounds pretty cool and flexible, I am not sure if we can already do it in the current chart easily, but I think that looks like pretty good native solution - with a bit less flexibility but without promoting the _CMD pattern.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org