You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/04 21:24:28 UTC

[GitHub] ArneBachmann opened a new pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts

ArneBachmann opened a new pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts
URL: https://github.com/apache/zookeeper/pull/801
 
 
   New attempt of PR #105:
   I added a `.gitattributes` file into the `bin/` folder with the startup scripts.
   It seems the official build servers build the ZK packages on a Windows machine (?), because even the Bash Shell scripts have CRLF line endings (extracted from the downloaded archive, not from a Git checkout), which caused bug ZK-2625, as reported by me.
   Since I don't have a build server myself and would build under Linux, I cannot check if this PR fixes the bug, please review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services