[GitHub] [spark] cloud-fan commented on a diff in pull request #41614: [SPARK-44060][SQL] Code-gen for build side outer shuffled hash join

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41614:
URL: https://github.com/apache/spark/pull/41614#discussion_r1254916041


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -484,7 +496,10 @@ case class ShuffledHashJoinExec(
          |    }
          |  }
          |
-         |  $consumeFullOuterJoinRow();
+         |  if ($foundMatch || $isFullOuterJoin) {

Review Comment:
   nit: we can statically remove or simply the condition:
   ```
   val consumeCode = if (isFullOuterJoin) {
     s"$consumeOuterJoinRow();"
   } else {
     s"""
       |if ($foundMatch) {
       |  $consumeOuterJoinRow();
       |}
     """
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org