You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2026/09/13 20:57:40 UTC
[PR] [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module [spark]
nchammas opened a new pull request, #58769:
URL: https://github.com/apache/spark/pull/58769
### What changes were proposed in this pull request?
Explicitly trigger the `pyspark-connect` test module on changes to `sbin/start-connect-server.sh`.
### Why are the changes needed?
This script is called here as part of PR CI: https://github.com/apache/spark/blob/24c15b0383f21b2e80b27435617f16933236491c/.github/workflows/build_and_test.yml#L757
This is run when any `pyspark` module is activated: https://github.com/nchammas/spark/blob/2d309efaf85b18d932acd837e81e60f83d6bad57/.github/workflows/build_and_test.yml#L110-L115
By adding this sbin script to the `pyspark-connect` module, we in turn activate the `pyspark_connect_old_client` test in the `build_and_test.yml` workflow.
It's a bit of a clunky relationship, and in the future I would like to refactor this so we are doing less in the workflow YAML and more in `sparktestsupport`. But for now, adding this line to the `pyspark-connect` makes the relationship more explicit.
The `stop-connect-server.sh` script is not tested by any part of CI as far as I can tell, so I've left it alone for now.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #58769:
URL: https://github.com/apache/spark/pull/58769#issuecomment-5789398647
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/15dc43e8045ca56ae746cb699a4f019fa09ee0cb
- merged into branch-4.x https://github.com/apache/spark/commit/a51137ec575b3454b2360c17665115303920498a
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #58769: [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module
URL: https://github.com/apache/spark/pull/58769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org