You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/28 19:12:24 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6837: [AIRFLOW-6266] Better asserts in test_views.py

nuclearpinguin commented on a change in pull request #6837: [AIRFLOW-6266] Better asserts in test_views.py
URL: https://github.com/apache/airflow/pull/6837#discussion_r361809416
 
 

 ##########
 File path: tests/www/test_views.py
 ##########
 @@ -95,7 +95,7 @@ def clear_table(cls, model):
 
     def check_content_in_response(self, text, resp, resp_code=200):
         resp_html = resp.data.decode('utf-8')
-        self.assertEqual(resp_code, resp.status_code)
+        assert resp_code == resp.status_code, str(resp_html)
 
 Review comment:
   ```suggestion
       self.assertEqual(resp_code, resp.status_code, msg=str(resp_html)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services