You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2019/03/08 11:38:00 UTC
[jira] [Commented] (TINKERPOP-2173) Incorrect reset of log level in
integration test
[ https://issues.apache.org/jira/browse/TINKERPOP-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787807#comment-16787807 ]
stephen mallette commented on TINKERPOP-2173:
---------------------------------------------
Looks like a cut/paste error maybe. Will you be submitting a pull request to fix that? If you are, it should be submitted to the tp33 branch as the problem exists there too.
> Incorrect reset of log level in integration test
> ------------------------------------------------
>
> Key: TINKERPOP-2173
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2173
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Divij Vaidya
> Priority: Trivial
>
> This issue is regarding GremlinServerIntegrateTest.java and other similar tests.
> In the @After method, the intention is to reset the log level which was temporarily changed in the @Before method for the duration of the test. However, instead of resetting to the original state, the code ends up setting the same log level again.
> Proposed fix:
> Do not mutate the previousLogLevel field in the @After methods [1][2]
> [1][https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java#L149]
> [2][https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java#L124]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)