You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/02 17:42:48 UTC
[GitHub] [flink] knaufk opened a new pull request #13534: [FLINK-19495] add documentation for avro-confluent format
knaufk opened a new pull request #13534:
URL: https://github.com/apache/flink/pull/13534
## What is the purpose of the change
* adding documentation for avro-confluent format
## Verifying this change
* build docs
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] knaufk merged pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
knaufk merged pull request #13534:
URL: https://github.com/apache/flink/pull/13534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702869296
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c942c423c14c35800e2a7ceb2f1d1b2889b87fca (Fri Oct 02 17:44:43 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13534:
URL: https://github.com/apache/flink/pull/13534#discussion_r500050642
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
Review comment:
nit: To be precise we could write something like:
```suggestion
When writing (serializing) a record with this format the Avro schema is inferred from the table schema and used to retrieve a schema id to be encoded with the data. The lookup is performed with in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
```
But I am also fine with the current version. It's just that the operation is not CREATE, but GET_OR_CREATE.
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
+
+The Avro Schema Registry format can only be used in conjunction with <a href="{% link dev/table/connectors/kafka.md %}"> Apache Kafka SQL connector</a> .
+
+Dependencies
+------------
+
+In order to use the Avro Schema Registry format the following dependencies are required for both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL Client JAR" markdown="1">
+You can download flink-sql-avro-confluent-registry from [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-avro-confluent-registry/{{site.version}}/flink-sql-avro-confluent-registry-{{site.version}}.jar)
+</div>
+<div data-lang="Maven dependency" markdown="1">
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro-confluent-registry</artifactId>
+ <version>{{ site.version }}</version>
+</dependency>
+{% endhighlight %}
+</div>
+</div>
Review comment:
Lets do it in the same way as we do it for other connectors:
```suggestion
| Maven dependency | SQL Client JAR |
| :----------------------------------- | :----------------------|
| `flink-avro-confluent-registry` | {% if site.is_stable %} [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-avro-confluent-registry/{{site.version}}/flink-sql-avro-confluent-registry-{{site.version}}.jar) {% else %} Only available for stable releases. {% endif %} |
```
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
+
+The Avro Schema Registry format can only be used in conjunction with <a href="{% link dev/table/connectors/kafka.md %}"> Apache Kafka SQL connector</a> .
Review comment:
```suggestion
The Avro Schema Registry format can only be used in conjunction with [Apache Kafka SQL connector]({% link dev/table/connectors/kafka.md %}) .
```
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
+
+The Avro Schema Registry format can only be used in conjunction with <a href="{% link dev/table/connectors/kafka.md %}"> Apache Kafka SQL connector</a> .
+
+Dependencies
+------------
+
+In order to use the Avro Schema Registry format the following dependencies are required for both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL Client JAR" markdown="1">
+You can download flink-sql-avro-confluent-registry from [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-avro-confluent-registry/{{site.version}}/flink-sql-avro-confluent-registry-{{site.version}}.jar)
+</div>
+<div data-lang="Maven dependency" markdown="1">
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro-confluent-registry</artifactId>
+ <version>{{ site.version }}</version>
+</dependency>
+{% endhighlight %}
+</div>
+</div>
+
+How to create a table with Avro-Confluent format
+----------------
+
+Here is an example to create a table using Kafka connector and Avro format.
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE user_behavior (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behavior STRING,
+ ts TIMESTAMP(3)
+) WITH (
+ 'connector' = 'kafka',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'topic' = 'user_behavior'
+ 'format' = 'avro-confluent',
+ 'avro-confluent.schema-registry.url' = 'http://localhost:8081',
+ 'avro-confluent.schema-registry.subject' = 'user_behavior'
+)
+{% endhighlight %}
+</div>
+</div>
+
+Format Options
+----------------
+
+<table class="table table-bordered">
Review comment:
I am good with this for now, as other formats/connector do that as well. At some point would be nice though to auto generate that from the `ConfigOptions`. We have the `ConfigOptions` already in place, we would probably need to add a dependency in the `flink-docs` module and replace this table with the auto generated one.
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
+
+The Avro Schema Registry format can only be used in conjunction with <a href="{% link dev/table/connectors/kafka.md %}"> Apache Kafka SQL connector</a> .
+
+Dependencies
+------------
+
+In order to use the Avro Schema Registry format the following dependencies are required for both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL Client JAR" markdown="1">
+You can download flink-sql-avro-confluent-registry from [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-avro-confluent-registry/{{site.version}}/flink-sql-avro-confluent-registry-{{site.version}}.jar)
+</div>
+<div data-lang="Maven dependency" markdown="1">
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro-confluent-registry</artifactId>
+ <version>{{ site.version }}</version>
+</dependency>
+{% endhighlight %}
+</div>
+</div>
+
+How to create a table with Avro-Confluent format
+----------------
+
+Here is an example to create a table using Kafka connector and Avro format.
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE user_behavior (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behavior STRING,
+ ts TIMESTAMP(3)
+) WITH (
+ 'connector' = 'kafka',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'topic' = 'user_behavior'
+ 'format' = 'avro-confluent',
+ 'avro-confluent.schema-registry.url' = 'http://localhost:8081',
+ 'avro-confluent.schema-registry.subject' = 'user_behavior'
+)
+{% endhighlight %}
+</div>
+</div>
+
+Format Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify what format to use, here should be <code>'avro-confluent'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>avro-confluent.schema-registry.url</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The URL of the Confluent Schema Registry to fetch/register schemas</td>
+ </tr>
+ <tr>
+ <td><h5>avro-confluent.schema-registry.subject</h5></td>
+ <td>required by sink</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The Confluent Schema Registry subject under which to register the schema used by this format during serialization</td>
+ </tr>
+ </tbody>
+</table>
+
+Data Type Mapping
+----------------
+
+Currently, the Avro schema is always derived from table schema. Explicitly defining an Avro schema is not supported yet.
+See the <a href="{% link dev/table/connectors/formats/avro.md%}#data-type-mapping"> Apache Avro Format</a> for the mapping between Avro and Flink DataTypes.
Review comment:
Let's stick to a single formatting:
```suggestion
See the [Apache Avro Format]({% link dev/table/connectors/formats/avro.md%}#data-type-mapping) for the mapping between Avro and Flink DataTypes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702878858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171",
"triggerID" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c942c423c14c35800e2a7ceb2f1d1b2889b87fca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] knaufk commented on a change in pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
knaufk commented on a change in pull request #13534:
URL: https://github.com/apache/flink/pull/13534#discussion_r500079229
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -0,0 +1,132 @@
+---
+title: "Confluent Avro Format"
+nav-title: Confluent Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-info">Format: Serialization Schema</span>
+<span class="label label-info">Format: Deserialization Schema</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Avro Schema Registry (``avro-confluent``) format allows you to read records that were serialized by the ``io.confluent.kafka.serializers.KafkaAvroSerializer`` and to write records that can in turn be read by the ``io.confluent.kafka.serializers.KafkaAvroDeserializer``.
+
+When reading (deserializing) a record with this format the Avro writer schema is fetched from the configured Confluent Schema Registry based on the schema version id encoded in the record while the reader schema is inferred from table schema.
+
+When writing (serializing) a record with this format the Avro schema is inferred from the table schema and registered in the configured Confluent Schema Registry under the [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) given in `avro-confluent.schema-registry.subject`.
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702878858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c942c423c14c35800e2a7ceb2f1d1b2889b87fca UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702878858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171",
"triggerID" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"triggerType" : "PUSH"
}, {
"hash" : "ebd70dfa5deb0adce2c5b01766ae71349d4aefc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebd70dfa5deb0adce2c5b01766ae71349d4aefc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c942c423c14c35800e2a7ceb2f1d1b2889b87fca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171)
* ebd70dfa5deb0adce2c5b01766ae71349d4aefc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702878858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171",
"triggerID" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c942c423c14c35800e2a7ceb2f1d1b2889b87fca Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13534: [FLINK-19495] add documentation for avro-confluent format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13534:
URL: https://github.com/apache/flink/pull/13534#issuecomment-702878858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171",
"triggerID" : "c942c423c14c35800e2a7ceb2f1d1b2889b87fca",
"triggerType" : "PUSH"
}, {
"hash" : "ebd70dfa5deb0adce2c5b01766ae71349d4aefc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebd70dfa5deb0adce2c5b01766ae71349d4aefc1",
"triggerType" : "PUSH"
}, {
"hash" : "6405538d0c5436e03f8da946a004196185a770d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6405538d0c5436e03f8da946a004196185a770d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c942c423c14c35800e2a7ceb2f1d1b2889b87fca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7171)
* ebd70dfa5deb0adce2c5b01766ae71349d4aefc1 UNKNOWN
* 6405538d0c5436e03f8da946a004196185a770d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org