[kudu-CR] [thirdparty] Upgrade to LLVM 11 and IWYU 0.15

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16768 )

Change subject: [thirdparty] Upgrade to LLVM 11 and IWYU 0.15
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16768/13/src/kudu/util/thread.cc
File src/kudu/util/thread.cc:

http://gerrit.cloudera.org:8080/#/c/16768/13/src/kudu/util/thread.cc@637
PS13, Line 637:     if (t!=nullptr) {
How t might be nullptr at this point with all the jazz above (e.g., at line 614, etc.)?


http://gerrit.cloudera.org:8080/#/c/16768/13/src/kudu/util/thread.cc@638
PS13, Line 638: int ret
This shades the 'ret' defined at line 636, so the code at 636 isn't going to work as expected (i.e. the condition at line 640 always evaluated to 'false').



-- 
To view, visit http://gerrit.cloudera.org:8080/16768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c32abe256978158617a4fe3a3c34e9bfd00fb2
Gerrit-Change-Number: 16768
Gerrit-PatchSet: 13
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 18:31:57 +0000
Gerrit-HasComments: Yes