You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/22 15:23:21 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
MaxGekk opened a new pull request #31295:
URL: https://github.com/apache/spark/pull/31295
### What changes were proposed in this pull request?
Rename `SessionCatalog.isTemporaryTable()` to `SessionCatalog.isTempView()`.
### Why are the changes needed?
To improve code maintenance. Currently, there are two methods that do the same but have different names:
```scala
def isTempView(nameParts: Seq[String]): Boolean
```
and
```scala
def isTemporaryTable(name: TableIdentifier): Boolean
```
### Does this PR introduce _any_ user-facing change?
Should not since `SessionCatalog` is not public API.
### How was this patch tested?
By running the existing tests:
```
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *SessionCatalogSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31295: [SPARK-34207][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31295:
URL: https://github.com/apache/spark/pull/31295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765567590
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38963/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765594769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38963/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765594769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38963/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765657091
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134376/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765657091
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134376/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31295: [SPARK-34207][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-766111972
Merged to master.
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765563429
@dongjoon-hyun @cloud-fan Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765639588
**[Test build #134376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134376/testReport)** for PR 31295 at commit [`8e33c19`](https://github.com/apache/spark/commit/8e33c19beeccf85440b3194c244bd6fe50e3c8ea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765553112
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38963/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765487842
**[Test build #134376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134376/testReport)** for PR 31295 at commit [`8e33c19`](https://github.com/apache/spark/commit/8e33c19beeccf85440b3194c244bd6fe50e3c8ea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31295: [MINOR][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765487842
**[Test build #134376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134376/testReport)** for PR 31295 at commit [`8e33c19`](https://github.com/apache/spark/commit/8e33c19beeccf85440b3194c244bd6fe50e3c8ea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31295: [SPARK-34207][SQL] Rename `isTemporaryTable` to `isTempView` in `SessionCatalog`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31295:
URL: https://github.com/apache/spark/pull/31295#issuecomment-765675739
@dongjoon-hyun I added an JIRA id to the PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org