You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2025/04/09 19:05:39 UTC
[PR] Fix sql:jdbc tests and shell entry [beam]
Abacn opened a new pull request, #34593:
URL: https://github.com/apache/beam/pull/34593
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34593:
URL: https://github.com/apache/beam/pull/34593#issuecomment-2790757442
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto merged PR #34593:
URL: https://github.com/apache/beam/pull/34593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34593:
URL: https://github.com/apache/beam/pull/34593#discussion_r2035983717
##########
sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java:
##########
@@ -103,7 +102,6 @@ public void tearDown() {
}
@Test
- @Ignore("https://jira.apache.org/jira/browse/BEAM-7582")
Review Comment:
BEAM-7582 is marked as fixed and checked passing locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34593:
URL: https://github.com/apache/beam/pull/34593#discussion_r2035982736
##########
sdks/java/extensions/sql/shell/build.gradle:
##########
@@ -1,59 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * License); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-plugins {
- id 'org.apache.beam.module'
- id 'application'
-}
-
-dependencies {
- implementation project(":sdks:java:extensions:sql:jdbc")
- permitUnusedDeclared project(":sdks:java:extensions:sql:jdbc")
-
- if (project.hasProperty("beam.sql.shell.bundled")) {
- project.getProperty("beam.sql.shell.bundled").tokenize(",").each {
- subproject ->
- implementation project(path: subproject)
- permitUnusedDeclared project(path: subproject)
- }
- }
-}
-
-processResources {
- filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
- 'beam.version': version,
- ]
-}
-
-mainClassName = "org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
-
-/**
- * Gradle console will interfere with SQL shell, so to run this command
- * we need to configure it:
- * - disable daemon with '--no-daemon';
- * - decrease verbosity with '--console plain';
- * - quiet it with '-q';
- *
- * So, correct gradle invocation to start the SQL shell
- * looks something like this:
- *
- * ./gradlew :sdks:java:extensions:sql:shell:run --console plain -q --no-daemon
Review Comment:
This does not work due to
```
* Where:
Build file '/Users/yathu/beam/sdks/java/extensions/sql/jdbc/build.gradle' line: 70
* What went wrong:
A problem occurred evaluating project ':sdks:java:extensions:sql:jdbc'.
> Could not resolve all dependencies for configuration ':sdks:java:extensions:sql:jdbc:shadowTestRuntimeClasspath'.
> Value for metadata of project :sdks:java:extensions:sql:jdbc has not been calculated yet.
```
Moved it to the same project of `sql:jdbc` and fixed the shell entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #34593:
URL: https://github.com/apache/beam/pull/34593#issuecomment-2790755574
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/34593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 72.04%. Comparing base [(`7caa09c`)](https://app.codecov.io/gh/apache/beam/commit/7caa09cc34ecb758cffda3f541d8b2073032f56d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5a4365f`)](https://app.codecov.io/gh/apache/beam/commit/5a4365f7b36dac827057009bffaf4f21fdb23f65?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 23 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #34593 +/- ##
============================================
- Coverage 72.31% 72.04% -0.27%
- Complexity 0 1480 +1480
============================================
Files 678 872 +194
Lines 99772 107845 +8073
Branches 0 1079 +1079
============================================
+ Hits 72146 77695 +5549
- Misses 26064 28204 +2140
- Partials 1562 1946 +384
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/34593/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/beam/pull/34593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.65% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/34593?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sql:jdbc tests and shell entry [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34593:
URL: https://github.com/apache/beam/pull/34593#issuecomment-2790754169
R: @Amar3tto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org