You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/12/20 15:39:11 UTC
svn commit: r1221283 - in /james/protocols/trunk:
api/src/main/java/org/apache/james/protocols/api/
api/src/main/java/org/apache/james/protocols/api/handler/
lmtp/src/main/java/org/apache/james/protocols/lmtp/
pop3/src/main/java/org/apache/james/protoc...
Author: norman
Date: Tue Dec 20 14:39:10 2011
New Revision: 1221283
URL: http://svn.apache.org/viewvc?rev=1221283&view=rev
Log:
Only small improvements and also remove 2 classes which are not needed anymore
Removed:
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Request.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPRequest.java
Modified:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/AbstractCommandDispatcher.java
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPMultiResponse.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocol.java
Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java?rev=1221283&r1=1221282&r2=1221283&view=diff
==============================================================================
--- james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java (original)
+++ james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java Tue Dec 20 14:39:10 2011
@@ -102,7 +102,7 @@ public abstract class AbstractResponse i
/**
* @see java.lang.Object#toString()
*/
- public String toString() {
+ public final String toString() {
return getLines().toString();
}
Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/AbstractCommandDispatcher.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/AbstractCommandDispatcher.java?rev=1221283&r1=1221282&r2=1221283&view=diff
==============================================================================
--- james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/AbstractCommandDispatcher.java (original)
+++ james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/AbstractCommandDispatcher.java Tue Dec 20 14:39:10 2011
@@ -45,9 +45,9 @@ public abstract class AbstractCommandDis
/**
* The list of available command handlers
*/
- private HashMap<String, List<CommandHandler<Session>>> commandHandlerMap = new HashMap<String, List<CommandHandler<Session>>>();
+ private final HashMap<String, List<CommandHandler<Session>>> commandHandlerMap = new HashMap<String, List<CommandHandler<Session>>>();
- private List<ProtocolHandlerResultHandler<Response, Session>> rHandlers = new ArrayList<ProtocolHandlerResultHandler<Response, Session>>();
+ private final List<ProtocolHandlerResultHandler<Response, Session>> rHandlers = new ArrayList<ProtocolHandlerResultHandler<Response, Session>>();
/**
* Add it to map (key as command name, value is an array list of CommandHandlers)
Modified: james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPMultiResponse.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPMultiResponse.java?rev=1221283&r1=1221282&r2=1221283&view=diff
==============================================================================
--- james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPMultiResponse.java (original)
+++ james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPMultiResponse.java Tue Dec 20 14:39:10 2011
@@ -26,7 +26,7 @@ import org.apache.james.protocols.api.Re
public class LMTPMultiResponse implements Response {
- private List<Response> responses = new ArrayList<Response>();
+ private final List<Response> responses = new ArrayList<Response>();
public LMTPMultiResponse(Response response) {
addResponse(response);
Modified: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocol.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocol.java?rev=1221283&r1=1221282&r2=1221283&view=diff
==============================================================================
--- james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocol.java (original)
+++ james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocol.java Tue Dec 20 14:39:10 2011
@@ -25,12 +25,19 @@ import org.apache.james.protocols.api.Pr
import org.apache.james.protocols.api.handler.ProtocolHandlerChain;
import org.apache.james.protocols.smtp.SMTPConfiguration;
import org.apache.james.protocols.smtp.SMTPSessionImpl;
+
+/**
+ * {@link ProtocolImpl} which creates {@link SMTPSessionImpl} instances
+ *
+ *
+ */
public class SMTPProtocol extends ProtocolImpl {
public SMTPProtocol(ProtocolHandlerChain chain, SMTPConfiguration config) {
super(chain, config);
}
+ @Override
public ProtocolSession newSession(ProtocolTransport transport) {
return new SMTPSessionImpl(logger, transport, (SMTPConfiguration) config);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org