You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/11/09 02:59:10 UTC
[GitHub] [incubator-inlong-website] leezng opened a new pull request #181: [INLONG-1771] Website readme error
leezng opened a new pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181
Fixes #apache/incubator-inlong#1771
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] gosonzhang merged pull request #181: [INLONG-1771] Website readme error
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] leezng commented on a change in pull request #181: [INLONG-1771] Website readme error
Posted by GitBox <gi...@apache.org>.
leezng commented on a change in pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181#discussion_r745260760
##########
File path: README.md
##########
@@ -5,9 +5,9 @@ https://inlong.apache.org/
## Prerequisite
-InLong website is powered by [docsite](https://docusaurus.io/).
-If your version of docsite is less than `2.0.0`,please upgrade to `2.0.0`.
-Please also make sure your node version is 14.x, versions higher than 14.x is not supported by docsite yet.
+InLong website is powered by [docusaurus](https://docusaurus.io/).
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] gosonzhang commented on pull request #181: [INLONG-1771] Website readme error
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181#issuecomment-963779511
@leezng, one word feels a problem, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] leezng commented on pull request #181: [INLONG-1771] Website readme error
Posted by GitBox <gi...@apache.org>.
leezng commented on pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181#issuecomment-963768831
@gosonzhang There is a text missing, please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] gosonzhang commented on a change in pull request #181: [INLONG-1771] Website readme error
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #181:
URL: https://github.com/apache/incubator-inlong-website/pull/181#discussion_r745257454
##########
File path: README.md
##########
@@ -5,9 +5,9 @@ https://inlong.apache.org/
## Prerequisite
-InLong website is powered by [docsite](https://docusaurus.io/).
-If your version of docsite is less than `2.0.0`,please upgrade to `2.0.0`.
-Please also make sure your node version is 14.x, versions higher than 14.x is not supported by docsite yet.
+InLong website is powered by [docusaurus](https://docusaurus.io/).
Review comment:
Should the first letter of "docusaurus" be capitalized?
I understand that this modification is to mark the name of our front-end component. If it is all lowercase, I find that it cannot be translated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org