You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/01 04:40:05 UTC
[GitHub] [cordova-android] breautek opened a new pull request #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
breautek opened a new pull request #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
There was an issue when building app bundles where it did not obey flags. This was an error in the original implementation where arguments was only propagated to gradle if the package type was "apk". This PR corrects this mistake.
Closes #873
### Description
<!-- Describe your changes in detail -->
Moved a line that pushes gradle arguments outside of the package type condition, as it is applicable
to both package types.
Unit tests was added for both package types to ensure they both have args filled out as expected.
### Testing
<!-- Please describe in detail how you tested your changes. -->
NPM test runs successfully, including 2 new tests that was added.
I've also ran `aapt` and `bundletool` to inspect the built files to ensure that the versionCode was as expected.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #941: fix: GH-873
App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.48% +0.05%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1197 +1
+ Misses 632 631 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.53% +0.10%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1198 +2
+ Misses 632 630 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `52.17% <0.00%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #941: fix: GH-873
App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.53% +0.10%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1198 +2
+ Misses 632 630 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `52.17% <0.00%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.53% +0.10%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1198 +2
+ Misses 632 630 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `52.17% <0.00%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.53% +0.10%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1198 +2
+ Misses 632 630 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `52.17% <0.00%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #941: fix:
GH-873 App bundle builds to obey --versionCode arguments
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #941: fix: GH-873 App bundle builds to obey --versionCode arguments
URL: https://github.com/apache/cordova-android/pull/941#issuecomment-607028674
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/c81cd871f891ad2bd3c81068a8b09b4b441b69df&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 65.42% 65.48% +0.05%
==========================================
Files 21 21
Lines 1828 1828
==========================================
+ Hits 1196 1197 +1
+ Misses 632 631 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/941/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=footer). Last update [c81cd87...ab20456](https://codecov.io/gh/apache/cordova-android/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org