[GitHub] [accumulo] keith-turner commented on a change in pull request #1157: fix #1153 preventing multiple threads working on same bulk file

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1157: fix #1153 preventing multiple threads working on same bulk file
URL: https://github.com/apache/accumulo/pull/1157#discussion_r282954559
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2437,6 +2442,16 @@ public void importMapFiles(long tid, Map<FileRef,MapFileInfo> fileMap, boolean s
           }
         }
       }
+
+      Iterator<FileRef> fiter = fileMap.keySet().iterator();
 
 Review comment:
   When I first wrote this code I used multiple Java 8 map methods.  Then I realized I couldn't.
   
   This particular code could have been implement using `fileMap.keySet().removeAll(bulkImporting)`.  However then there would be no logging.  I thought the logging was important, so wrote it this way which was the most efficient way I could think of writing it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services