You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Ruhshan (via GitHub)" <gi...@apache.org> on 2023/08/01 19:39:39 UTC
[PR] Eventmesh enhancement 4093 (eventmesh)
Ruhshan opened a new pull request, #4315:
URL: https://github.com/apache/eventmesh/pull/4315
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4093.
### Motivation
There were some duplicated logic within different methods in MessageUtils.
### Modifications
Move reusable logics to separate method and make use of those methods where applicable
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4093]Repeat code extraction as method.[MessageUtils] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4315:
URL: https://github.com/apache/eventmesh/pull/4315#issuecomment-1661403602
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4315](https://app.codecov.io/gh/apache/eventmesh/pull/4315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5bf43d9) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/dd40227299773c40d92ae86a484d5ec4f7df4980?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dd40227) will **decrease** coverage by `0.03%`.
> The diff coverage is `45.71%`.
> :exclamation: Current head 5bf43d9 differs from pull request most recent head eb9b76c. Consider uploading reports for the commit eb9b76c to get more accurate results
```diff
@@ Coverage Diff @@
## master #4315 +/- ##
============================================
- Coverage 16.35% 16.33% -0.03%
- Complexity 1359 1362 +3
============================================
Files 594 594
Lines 25419 25388 -31
Branches 2394 2380 -14
============================================
- Hits 4158 4147 -11
+ Misses 20838 20819 -19
+ Partials 423 422 -1
```
| [Files Changed](https://app.codecov.io/gh/apache/eventmesh/pull/4315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/eventmesh/client/tcp/common/MessageUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9jb21tb24vTWVzc2FnZVV0aWxzLmphdmE=) | `49.25% <45.71%> (+7.76%)` | :arrow_up: |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4315/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4093]Repeat code extraction as method.[MessageUtils] (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4315:
URL: https://github.com/apache/eventmesh/pull/4315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org