You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2020/04/08 10:18:33 UTC
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/
-----------------------------------------------------------
(Updated April 8, 2020, 10:18 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
Included role merge at the time of policy merge
Repository: ranger
Description
-------
Handling the scenario when non-existing policy send with mergeIfExist=true
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
Diff: https://reviews.apache.org/r/72325/diff/2/
Changes: https://reviews.apache.org/r/72325/diff/1-2/
Testing (updated)
-------
Test case:
Creating non-existing policy with below param
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: New policy should be created.
Creating policy with below param and role which is already exist
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: role should get merged.
Thanks,
Dineshkumar Yadav
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/#review220304
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On April 13, 2020, 12:51 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72325/
> -----------------------------------------------------------
>
> (Updated April 13, 2020, 12:51 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Handling the scenario when non-existing policy send with mergeIfExist=true
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
> security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
>
>
> Diff: https://reviews.apache.org/r/72325/diff/4/
>
>
> Testing
> -------
>
> Test case:
>
> Creating non-existing policy with below param
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: New policy should be created.
>
> Creating policy with below param and role which is already exist
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: role should get merged.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/
-----------------------------------------------------------
(Updated April 13, 2020, 12:51 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
Removing policy condition functionality when policy send with mergeIfExist=true
Repository: ranger
Description
-------
Handling the scenario when non-existing policy send with mergeIfExist=true
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
Diff: https://reviews.apache.org/r/72325/diff/4/
Changes: https://reviews.apache.org/r/72325/diff/3-4/
Testing (updated)
-------
Test case:
Creating non-existing policy with below param
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: New policy should be created.
Creating policy with below param and role which is already exist
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: role should get merged.
Thanks,
Dineshkumar Yadav
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
Posted by Dineshkumar Yadav <di...@outlook.com>.
> On April 10, 2020, 1:21 p.m., Pradeep Agrawal wrote:
> >
As I am removing policy condition functionality, it is not relevant now, will provide same functionality in different patch and will take care your of your comment.
- Dineshkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/#review220280
-----------------------------------------------------------
On April 13, 2020, 12:51 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72325/
> -----------------------------------------------------------
>
> (Updated April 13, 2020, 12:51 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Handling the scenario when non-existing policy send with mergeIfExist=true
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
> security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
>
>
> Diff: https://reviews.apache.org/r/72325/diff/4/
>
>
> Testing
> -------
>
> Test case:
>
> Creating non-existing policy with below param
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: New policy should be created.
>
> Creating policy with below param and role which is already exist
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: role should get merged.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/#review220280
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Line 880 (original), 999 (patched)
<https://reviews.apache.org/r/72325/#comment308614>
if this is not required, the please remove it.
- Pradeep Agrawal
On April 9, 2020, 1:25 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72325/
> -----------------------------------------------------------
>
> (Updated April 9, 2020, 1:25 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Handling the scenario when non-existing policy send with mergeIfExist=true
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
> security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
>
>
> Diff: https://reviews.apache.org/r/72325/diff/3/
>
>
> Testing
> -------
>
> Test case:
>
> Creating non-existing policy with below param
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: New policy should be created.
>
> Creating policy with below param and role which is already exist
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: role should get merged.
>
> Creating policy with below param and policy condition in kafka service which is already exist
> a) mergeIfExists=true
> b) serviceName
> c) policyName
>
> Expected: condition should get merged.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 72325: RANGER-2772 : Adding the functionality of
merging the policy
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72325/
-----------------------------------------------------------
(Updated April 9, 2020, 1:25 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
Added merge functionality for policy condition
Repository: ranger
Description
-------
Handling the scenario when non-existing policy send with mergeIfExist=true
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 38b49820b
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java d85028c95
Diff: https://reviews.apache.org/r/72325/diff/3/
Changes: https://reviews.apache.org/r/72325/diff/2-3/
Testing (updated)
-------
Test case:
Creating non-existing policy with below param
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: New policy should be created.
Creating policy with below param and role which is already exist
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: role should get merged.
Creating policy with below param and policy condition in kafka service which is already exist
a) mergeIfExists=true
b) serviceName
c) policyName
Expected: condition should get merged.
Thanks,
Dineshkumar Yadav