You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/09 05:36:14 UTC

[GitHub] [airflow] j-y-matsubara commented on a change in pull request #8757: Fix the incorrect description of pod_mutation_hook in kubernetes.rst

j-y-matsubara commented on a change in pull request #8757:
URL: https://github.com/apache/airflow/pull/8757#discussion_r422455491



##########
File path: docs/kubernetes.rst
##########
@@ -40,11 +40,44 @@ that has the ability to mutate pod objects before sending them to the Kubernetes
 for scheduling. It receives a single argument as a reference to pod objects, and
 is expected to alter its attributes.
 
-This could be used, for instance, to add sidecar or init containers
+This could be used, for instance, to add init containers

Review comment:
       How is is made and used for sidecar?  
   We can mutation pod object by using pod_mutation_hook, but I think we can not add any containers, excluding the init container ( in the case of using kubernetes_request_factory.py ).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org