You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/30 19:24:30 UTC
[GitHub] [ignite] zstan opened a new pull request #8518: IGNITE-13772 Calcite, NPE on join.
zstan opened a new pull request #8518:
URL: https://github.com/apache/ignite/pull/8518
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] korlov42 commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r540033343
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -69,6 +81,22 @@
/** */
protected int nodesCnt = 3;
+ /** */
+ @Parameterized.Parameters(name = "Execution direction = {0}")
+ public static List<Object[]> parameters() {
+ ArrayList<Object[]> params = new ArrayList<>();
+
+ params.add(new Object[]{true});
+ params.add(new Object[]{false});
+ params.add(new Object[]{null});
+
+ return params;
+ }
+
+ /** Execution direction. */
+ @Parameterized.Parameter
+ public static Boolean execDir;
Review comment:
@zstan please see my suggestion here: https://github.com/gridgain/apache-ignite/pull/259.
Also introducing params in the abstract class breaks ContinuousExecutionTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dspavlov closed pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
dspavlov closed pull request #8518:
URL: https://github.com/apache/ignite/pull/8518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r539998875
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -69,6 +81,22 @@
/** */
protected int nodesCnt = 3;
+ /** */
+ @Parameterized.Parameters(name = "Execution direction = {0}")
+ public static List<Object[]> parameters() {
+ ArrayList<Object[]> params = new ArrayList<>();
+
+ params.add(new Object[]{true});
+ params.add(new Object[]{false});
+ params.add(new Object[]{null});
+
+ return params;
+ }
+
+ /** Execution direction. */
+ @Parameterized.Parameter
+ public static Boolean execDir;
Review comment:
can`t use enum here, need to be iterable as i understand, does i missed something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r540211412
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -69,6 +81,22 @@
/** */
protected int nodesCnt = 3;
+ /** */
+ @Parameterized.Parameters(name = "Execution direction = {0}")
+ public static List<Object[]> parameters() {
+ ArrayList<Object[]> params = new ArrayList<>();
+
+ params.add(new Object[]{true});
+ params.add(new Object[]{false});
+ params.add(new Object[]{null});
+
+ return params;
+ }
+
+ /** Execution direction. */
+ @Parameterized.Parameter
+ public static Boolean execDir;
Review comment:
thanks ! done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r538174690
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -114,6 +142,59 @@ public void setup() throws Exception {
}
}
+ /** Task reordering executor. */
+ private static class IgniteRandomStripedThreadPoolExecutor extends IgniteStripedThreadPoolExecutor {
Review comment:
Naming suggestion: IgniteTestStripedThreadPoolExecutor. Not only random mode is supported
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dspavlov commented on pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
dspavlov commented on pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#issuecomment-894335836
This PR is associated with a resolved ticket. Closing the PR, please reopen it if you still need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r538163935
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/ExecutionTest.java
##########
@@ -66,6 +68,7 @@
*/
@SuppressWarnings("TypeMayBeWeakened")
@WithSystemProperty(key = "calcite.debug", value = "true")
+@RunWith(Parameterized.class)
Review comment:
Why you don't move this annotation to the base class `AbstractExecutionTest `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r538173782
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -69,6 +81,22 @@
/** */
protected int nodesCnt = 3;
+ /** */
+ @Parameterized.Parameters(name = "Execution direction = {0}")
+ public static List<Object[]> parameters() {
+ ArrayList<Object[]> params = new ArrayList<>();
+
+ params.add(new Object[]{true});
+ params.add(new Object[]{false});
+ params.add(new Object[]{null});
+
+ return params;
+ }
+
+ /** Execution direction. */
+ @Parameterized.Parameter
+ public static Boolean execDir;
Review comment:
May be enum usage will be more appropriate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org