You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/21 06:18:42 UTC

[GitHub] [hudi] xicm commented on a diff in pull request #6149: [HUDI-4426] The implementation of Clean is inconsistent with CLEANER_COMMITS_RETAINED

xicm commented on code in PR #6149:
URL: https://github.com/apache/hudi/pull/6149#discussion_r926292377


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -1453,8 +1454,7 @@ private void testPendingCompactions(HoodieWriteConfig config, int expNumFilesDel
         .withLogFile(partition, "fileId5", 1, 2)
         .addCommit("011")
         .withBaseFilesInPartition(partition, "fileId7")
-        .withLogFile(partition, "fileId7", 1, 2)
-        .addCommit("013");

Review Comment:
   As commented, the earliest instance is 009,  delete commit 013 here.
   https://github.com/apache/hudi/blob/ab62ffd77af6bfa92dd111072efd9f684a99bd94/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java#L1171-L1188



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org