You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:49:27 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4721: Queries with invalid type parameter should return 400s, not 500s

ocket8888 commented on a change in pull request #4721:
URL: https://github.com/apache/trafficcontrol/pull/4721#discussion_r430742107



##########
File path: CHANGELOG.md
##########
@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Removed audit logging from the `POST /api/x/serverchecks` Traffic Ops API endpoint in order to reduce audit log spam
 - Fixed audit logging from the `/jobs` APIs to bring them back to the same level of information provided by TO-Perl
 - Fixed update procedure of servers, so that if a server is linked to one or more delivery services, you cannot change its "cdn".
+- Fixed `cachegroups` READ endpoint, so that if a request is made with the `type` specified as a non integer value, you get back a `400` with error details, instead of a `500`.

Review comment:
       I see that you're just following everyone's example here but: Why don't we link to the issue that was resolved?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org