(tooling-trusted-release) branch main updated: Move failed vote files back a phase

[sb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git


The following commit(s) were added to refs/heads/main by this push:
     new e38fa54  Move failed vote files back a phase
e38fa54 is described below

commit e38fa547975ee5156e0b2d8cbf8ba0f80e277b42
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Mon Mar 31 18:51:54 2025 +0100

    Move failed vote files back a phase
---
 atr/routes/candidate.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/atr/routes/candidate.py b/atr/routes/candidate.py
index c0c7301..fff288d 100644
--- a/atr/routes/candidate.py
+++ b/atr/routes/candidate.py
@@ -321,11 +321,17 @@ async def _resolve_post(session: routes.CommitterSession) -> response.Response:
 
             await data.commit()
 
+    await _resolve_post_files(project_name, release, vote_result)
+    return await session.redirect(resolve, success=success_message)
+
+
+async def _resolve_post_files(project_name: str, release: models.Release, vote_result: str) -> None:
     # TODO: Obtain a lock for this
     source = str(util.get_release_candidate_dir() / project_name / release.version)
-    target = str(util.get_release_preview_dir() / project_name / release.version)
+    if vote_result == "passed":
+        target = str(util.get_release_preview_dir() / project_name / release.version)
+    else:
+        target = str(util.get_release_candidate_draft_dir() / project_name / release.version)
     if await aiofiles.os.path.exists(target):
-        return await session.redirect(resolve, error="Release already exists")
+        raise base.ASFQuartException("Release already exists", errorcode=400)
     await aioshutil.move(source, target)
-
-    return await session.redirect(resolve, success=success_message)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org