You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sdap.apache.org by rk...@apache.org on 2024/03/06 18:29:08 UTC

(incubator-sdap-ingester) 02/03: Try just using destructor instead of explicit close() calls

This is an automated email from the ASF dual-hosted git repository.

rkk pushed a commit to branch SDAP-512
in repository https://gitbox.apache.org/repos/asf/incubator-sdap-ingester.git

commit 30d5b1d6f890963025960087c863424079c660fd
Author: rileykk <ri...@jpl.nasa.gov>
AuthorDate: Wed Mar 6 10:22:36 2024 -0800

    Try just using destructor instead of explicit close() calls
---
 granule_ingester/granule_ingester/pipeline/Pipeline.py     | 9 +++++----
 granule_ingester/granule_ingester/writers/MetadataStore.py | 3 +++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/granule_ingester/granule_ingester/pipeline/Pipeline.py b/granule_ingester/granule_ingester/pipeline/Pipeline.py
index 541700f..662aa46 100644
--- a/granule_ingester/granule_ingester/pipeline/Pipeline.py
+++ b/granule_ingester/granule_ingester/pipeline/Pipeline.py
@@ -257,11 +257,12 @@ class Pipeline:
                 logger.info(f"Now writing generated tiles...")
 
                 await self._data_store_factory().save_batch(results)
+                await self._metadata_store_factory().save_batch(results)
 
-                metadata_store = self._metadata_store_factory()
-                await metadata_store.save_batch(results)
-
-                metadata_store.close()
+                # metadata_store = self._metadata_store_factory()
+                # await metadata_store.save_batch(results)
+                #
+                # metadata_store.close()
 
         end = time.perf_counter()
         logger.info("Pipeline finished in {} seconds".format(end - start))
diff --git a/granule_ingester/granule_ingester/writers/MetadataStore.py b/granule_ingester/granule_ingester/writers/MetadataStore.py
index 7296075..e1e317b 100644
--- a/granule_ingester/granule_ingester/writers/MetadataStore.py
+++ b/granule_ingester/granule_ingester/writers/MetadataStore.py
@@ -41,3 +41,6 @@ class MetadataStore(HealthCheck, ABC):
     def close(self) -> None:
         pass
 
+    def __del__(self):
+        self.close()
+