You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/16 23:42:36 UTC
Review Request 60901: Use a consistent preprocessor check for
ENABLE_PORT_MAPPING_ISOLATOR.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/
-----------------------------------------------------------
Review request for mesos and Qian Zhang.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
There's no need to also check for Windows when testing the
ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
Linux-specific features.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
Diff: https://reviews.apache.org/r/60901/diff/1/
Testing
-------
make check (Frdora 26).
Thanks,
James Peach
Re: Review Request 60901: Use a consistent preprocessor check for
ENABLE_PORT_MAPPING_ISOLATOR.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/#review183437
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 16, 2017, 11:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60901/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 11:42 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There's no need to also check for Windows when testing the
> ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
> ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
> Linux-specific features.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/60901/diff/4/
>
>
> Testing
> -------
>
> make check (Frdora 26).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60901: Use a consistent preprocessor check for
ENABLE_PORT_MAPPING_ISOLATOR.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/#review180650
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60491, 60493, 60494, 60764, 60901]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 16, 2017, 11:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60901/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 11:42 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There's no need to also check for Windows when testing the
> ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
> ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
> Linux-specific features.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/60901/diff/1/
>
>
> Testing
> -------
>
> make check (Frdora 26).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60901: Use a consistent preprocessor check for
ENABLE_PORT_MAPPING_ISOLATOR.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/#review180652
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On July 17, 2017, 7:42 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60901/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 7:42 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There's no need to also check for Windows when testing the
> ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
> ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
> Linux-specific features.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/60901/diff/1/
>
>
> Testing
> -------
>
> make check (Frdora 26).
>
>
> Thanks,
>
> James Peach
>
>