You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/08 23:44:47 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #198: [YUNIKORN-438] Wait for sync after apiFactory start

wilfred-s commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/198#discussion_r502079728



##########
File path: pkg/client/apifactory.go
##########
@@ -203,6 +206,10 @@ func (s *APIFactory) Start() {
 	// launch clients
 	if !s.IsTestingMode() {
 		s.clients.Run(s.stopChan)
+		if err := s.WaitForSync(); err != nil {

Review comment:
       We already know we're not in test mode why are we not calling `s.clients.WaitForSync(time.Second, 30*time.Second)` directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org