[GitHub] [kylin] ITzhangqiang commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

[GitBox <gi...@apache.org>]

ITzhangqiang commented on a change in pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#discussion_r472617186



##########
File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java
##########
@@ -101,6 +102,7 @@ public int run(String[] args) throws Exception {
 
             // Automatic config !
             HFileOutputFormat3.configureIncrementalLoad(job, htable);
+            tmpPartitionFilePath = new Path(TotalOrderPartitioner.getPartitionFile(job.getConfiguration()));

Review comment:
       I‘m sure，that‘s why I put  'TotalOrderPartitioner.getPartitionFile' up on the 'reconfigurePartitions'.

##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
##########
@@ -69,13 +68,6 @@ public static Configuration getCurrentConfiguration() {
     }
 
     public static Configuration healSickConfig(Configuration conf) {
-        // https://issues.apache.org/jira/browse/KYLIN-953

Review comment:
       I checked,there is no affects on others.Because these two configurations belong to Hbase, where Hbase is used, HbaseConnection is used to get the configuration.And in HBaseConnection#newHBaseConfiguration,special treatment is given to these two configurations in this method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org