You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Denis Sadowski (JIRA)" <ji...@codehaus.org> on 2008/03/03 18:30:28 UTC

[jira] Created: (MASSEMBLY-287) Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.

Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.
----------------------------------------------------------------------------------------

                 Key: MASSEMBLY-287
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-287
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2-beta-2
            Reporter: Denis Sadowski


Configured my assembly plugin as follows:

			<plugin>
				<artifactId>maven-assembly-plugin</artifactId>
				<configuration>
					<descriptors>
						<descriptor> target/classes/maven/assembly/assembly.xml</descriptor>
					</descriptors>
				</configuration>
				<executions>
					<execution>
						<id>make-assembly</id>
						<phase>package</phase>
						<goals>
							<goal>attached</goal>
						</goals>
					</execution>
				</executions>
			</plugin>

I want to skip running this assembly plugin, so I attempted to use the -DskipAssembly=true command line parameter to no avail, the plugin still runs. 

I am however able to change other parameters through the command line, such as -DappendAssemblyId=false, and the change is picked up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-287) Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.

Posted by "Petar Tahchiev (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Petar Tahchiev updated MASSEMBLY-287:
-------------------------------------

    Attachment: massembly-287-source.txt

This is a patch that first extracts the executionProperties from the session and then checks if the skipAssembly property is set there.

IMPORTANT!!!
This patch should be applied once the MASSEMBLY-331 issue has been resolved and its patches have been applied.

HTH, Petar.

> Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.
> ----------------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-287
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-287
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>            Reporter: Denis Sadowski
>         Attachments: massembly-287-source.txt
>
>
> Configured my assembly plugin as follows:
> 			<plugin>
> 				<artifactId>maven-assembly-plugin</artifactId>
> 				<configuration>
> 					<descriptors>
> 						<descriptor> target/classes/maven/assembly/assembly.xml</descriptor>
> 					</descriptors>
> 				</configuration>
> 				<executions>
> 					<execution>
> 						<id>make-assembly</id>
> 						<phase>package</phase>
> 						<goals>
> 							<goal>attached</goal>
> 						</goals>
> 					</execution>
> 				</executions>
> 			</plugin>
> I want to skip running this assembly plugin, so I attempted to use the -DskipAssembly=true command line parameter to no avail, the plugin still runs. 
> I am however able to change other parameters through the command line, such as -DappendAssemblyId=false, and the change is picked up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-287) Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MASSEMBLY-287.
--------------------------------

         Assignee: John Casey
       Resolution: Fixed
    Fix Version/s: 2.2-beta-3

Petar,

Actually, we can fix this using the plugin-parameter annotation:

{noformat}
/**
 * @parameter expression="${skipAssembly}" default-value="false"
 */
private boolean skipAssembly;
{noformat}

I did apply your integration-test patch, though. Thanks.

> Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.
> ----------------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-287
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-287
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>            Reporter: Denis Sadowski
>            Assignee: John Casey
>             Fix For: 2.2-beta-3
>
>         Attachments: massembly-287-source.txt, massemby287.zip
>
>
> Configured my assembly plugin as follows:
> 			<plugin>
> 				<artifactId>maven-assembly-plugin</artifactId>
> 				<configuration>
> 					<descriptors>
> 						<descriptor> target/classes/maven/assembly/assembly.xml</descriptor>
> 					</descriptors>
> 				</configuration>
> 				<executions>
> 					<execution>
> 						<id>make-assembly</id>
> 						<phase>package</phase>
> 						<goals>
> 							<goal>attached</goal>
> 						</goals>
> 					</execution>
> 				</executions>
> 			</plugin>
> I want to skip running this assembly plugin, so I attempted to use the -DskipAssembly=true command line parameter to no avail, the plugin still runs. 
> I am however able to change other parameters through the command line, such as -DappendAssemblyId=false, and the change is picked up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-287) Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.

Posted by "Petar Tahchiev (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Petar Tahchiev updated MASSEMBLY-287:
-------------------------------------

    Attachment: massemby287.zip

OK,

here is an integration test that verifies that when you specify the skipAssembly property on the command line no artifact is produced. I have also bundled a better version of the patch. Remeber you still have to apply the 331 before applying this one.

> Unable to pass -DskipAssembly=true through the command line to skip the assembly plugin.
> ----------------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-287
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-287
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>            Reporter: Denis Sadowski
>         Attachments: massembly-287-source.txt, massemby287.zip
>
>
> Configured my assembly plugin as follows:
> 			<plugin>
> 				<artifactId>maven-assembly-plugin</artifactId>
> 				<configuration>
> 					<descriptors>
> 						<descriptor> target/classes/maven/assembly/assembly.xml</descriptor>
> 					</descriptors>
> 				</configuration>
> 				<executions>
> 					<execution>
> 						<id>make-assembly</id>
> 						<phase>package</phase>
> 						<goals>
> 							<goal>attached</goal>
> 						</goals>
> 					</execution>
> 				</executions>
> 			</plugin>
> I want to skip running this assembly plugin, so I attempted to use the -DskipAssembly=true command line parameter to no avail, the plugin still runs. 
> I am however able to change other parameters through the command line, such as -DappendAssemblyId=false, and the change is picked up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira