You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/10/19 17:26:18 UTC

[GitHub] [couchdb] kocolosk commented on a change in pull request #3794: Include shard uuids in db_info update sequences

kocolosk commented on a change in pull request #3794:
URL: https://github.com/apache/couchdb/pull/3794#discussion_r732091076



##########
File path: src/fabric/src/fabric_view_changes.erl
##########
@@ -410,6 +413,12 @@ unpack_seq_decode_term(Opaque) ->
     binary_to_term(couch_util:decodeBase64Url(Opaque)).
 
 
+% This is used for testing and for remsh debugging
+unpack_seqs(Packed) ->

Review comment:
       Nit: I think it's going to be confusing that `unpack_seqs/1` and `unpack_seqs/2` return different data structures. Might be worth a type signature as a comment. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org