You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/06/09 01:17:28 UTC
[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures
Hello Grant Henke, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7129
to review the following change.
Change subject: Tweak build-and-test.sh to fix spark1 test failures
......................................................................
Tweak build-and-test.sh to fix spark1 test failures
Maven seems to be caching old artifacts which is leading to
hard-to-diagnose test failures in some branches. This commit changes the
spark1 test to do a full clean/rebuild instead of selectively removing
the kudu-spark target dir. I've also snuck in a change to add the -B
'batch' flag to maven invocations, which should help with the verbose
download progress log spam.
Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
---
M build-support/jenkins/build-and-test.sh
1 file changed, 8 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/7129/1
--
To view, visit http://gerrit.cloudera.org:8080/7129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Tweak build-and-test.sh to fix spark1 test failures
......................................................................
Tweak build-and-test.sh to fix spark1 test failures
Maven seems to be caching old artifacts which is leading to
hard-to-diagnose test failures in some branches. This commit changes the
spark1 test to do a full clean/rebuild instead of selectively removing
the kudu-spark target dir. I've also snuck in a change to add the -B
'batch' flag to maven invocations, which should help with the verbose
download progress log spam, as well as the -Dmaven.javadoc.skip flag in
order to speed up the builds, since javadocs aren't necessary.
Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Reviewed-on: http://gerrit.cloudera.org:8080/7129
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
1 file changed, 11 insertions(+), 14 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Tweak build-and-test.sh to fix spark1 test failures
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7129/1//COMMIT_MSG
Commit Message:
Line 12: the kudu-spark target dir. I've also snuck in a change to add the -B
Please also note the change to no longer build javadocs.
http://gerrit.cloudera.org:8080/#/c/7129/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
Line 358: MVN_FLAGS="$MVN_FLAGS -B -Dsurefire.rerunFailingTestsCount=3 -Dfailsafe.rerunFailingTestsCount=3 -Dmaven.javadoc.skip"
Could you spread this out line-by-line? Makes it easier to add new flags and do a visual diff:
MVN_FLAGS="$MVN_FLAGS -B"
MVN_FLAGS="$MVN_FLAGS -Dsurefire..."
...
Line 363: # If there are no failure, rerun the build with Spark 1.x with Scala 2.10.
"If there are no failure" isn't grammatically correct.
Line 365: else if ! mvn $MVN_FLAGS -Dtest="org.apache.kudu.spark.*.*" -Pspark_2.10 clean verify ; then
Need to use elif in bash.
--
To view, visit http://gerrit.cloudera.org:8080/7129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7129
to look at the new patch set (#2).
Change subject: Tweak build-and-test.sh to fix spark1 test failures
......................................................................
Tweak build-and-test.sh to fix spark1 test failures
Maven seems to be caching old artifacts which is leading to
hard-to-diagnose test failures in some branches. This commit changes the
spark1 test to do a full clean/rebuild instead of selectively removing
the kudu-spark target dir. I've also snuck in a change to add the -B
'batch' flag to maven invocations, which should help with the verbose
download progress log spam, as well as the -Dmaven.javadoc.skip flag in
order to speed up the builds, since javadocs aren't necessary.
Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
---
M build-support/jenkins/build-and-test.sh
1 file changed, 11 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/7129/2
--
To view, visit http://gerrit.cloudera.org:8080/7129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Tweak build-and-test.sh to fix spark1 test failures
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No