You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 22:12:25 UTC
[GitHub] [airflow] dstandish commented on a diff in pull request #25419: WIP: Create a pluggable DatasetEventManager
dstandish commented on code in PR #25419:
URL: https://github.com/apache/airflow/pull/25419#discussion_r937179650
##########
airflow/models/dataset.py:
##########
@@ -203,6 +206,44 @@ def __repr__(self):
return f"{self.__class__.__name__}({', '.join(args)})"
+class DatasetEventManager(LoggingMixin):
+ """
+ A pluggable class that manages operations for dataset events.
+
+ The intent is to have one place to handle all DatasetEvent-related operations, so different
+ Airflow deployments can use plugins that broadcast dataset events to each other.
+ """
+
+ def register_dataset_change(
+ self, *, task_instance=None, dataset=None, session: Session = NEW_SESSION
Review Comment:
should add `extra` to signature here and pass to DatasetEvent
should we consider renaming it `payload`? wdyt @jedcunningham @ashb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org