You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2025/07/08 16:31:26 UTC

[PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

fjtirado opened a new pull request, #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980

   Fix https://github.com/apache/incubator-kie-kogito-runtimes/issues/3979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192994600


##########
api/kogito-services/src/main/java/org/kie/kogito/services/jobs/impl/InMemoryJobService.java:
##########
@@ -117,17 +103,14 @@ public String rescheduleJob(JobDescription jobDescription) {
 
     protected long calculateDelay(JobDescription description) {
         long delay = Duration.between(ZonedDateTime.now(), description.expirationTime().get()).toMillis();
-        if (delay <= 0) {
-            return 1;
-        }
-        return delay;
+        return delay <= 0 ? 1 : delay;
     }
 
     @Override
     public void close() throws Exception {
         LOGGER.info("closing in memory job service");
-        scheduledJobs.clear();
         scheduledJobs.forEach((k, v) -> v.cancel(true));

Review Comment:
   Clear before forEach was an ominous bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192997651


##########
kogito-serverless-workflow/kogito-serverless-workflow-executor-core/src/test/java/org/kie/kogito/serverless/workflow/executor/StaticFluentWorkflowApplicationTest.java:
##########
@@ -165,13 +158,6 @@ void testSwitchLoop() throws InterruptedException, TimeoutException {
         OperationStateBuilder sleepState = operation().action(call(expr("inc", ".count=.count+1")).sleepAfter(Duration.ofSeconds(1)));
 
         try (StaticWorkflowApplication application = StaticWorkflowApplication.create()) {
-            ProcessConfig processConfig = application.config().get(ProcessConfig.class);

Review Comment:
   This test should not have been modified, but StaticWorkflowApplication changed to make it work, as in this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#issuecomment-3052143565

   
   **PR job** `#9` was: **UNSTABLE**
   Possible explanation: This should be test failures
   
   
   <details>
   <summary><b>Reproducer</b></summary>
   
   
   
   build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980 --skipParallelCheckout
   
   NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
   
   </details>
   
   
   Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3980/9/display/redirect
   
   **Test results:**
   - PASSED: 2807
   - FAILED: 2
   
   Those are the test failures: 
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3980/9/testReport/org.kie.kogito.codegen.rules/PublishEventBusinessRuleIT/testBusinessRuleProcessStartToEndWithVariableTracked/">org.kie.kogito.codegen.rules.PublishEventBusinessRuleIT.testBusinessRuleProcessStartToEndWithVariableTracked</a></summary>
   <br/>Expected size: 10 but was: 21 in:<br/>[ProcessInstanceStateDataEvent {specVersion=1.0, id='bda05655-45b2-4773-b600-7bbfcd4fe756', source=http://myhost/TimerProcess, type='ProcessInstanceStateDataEvent', time=2025-07-09T05:59:47.954384642-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processType=BPMN, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, businessKey=null, processName=TimerProcess, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=1, roles=null, cloudEventId=null ,cloudEventSource=null], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN
 , kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='895508ee-d53c-472d-a25d-8ec45b03e4df', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.951119031-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, connectionNodeInstanceId=null, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=45adcefd-d719-4f19-a05f-7dd1c3b355af, data={}], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', 
 kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='3fce5a25-252b-48fa-ae8e-4586bc03eb1b', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.951362428-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=9eefbc6d-7334-4f62-ab80-fb87e9bab593, data={}], kogitoProcessInsta
 nceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='51b6633d-0897-475d-bd50-a50a8cda88c0', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.951644300-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=UserTask_1, nodeName=User Task 1, 
 nodeType=HumanTaskNode, nodeInstanceId=5f781d52-7a3c-4db8-b136-7e017aa654ba, data={}], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='24ff3fe8-34d8-4a42-8956-fcd2604183ca', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T05:59:47.952479542-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=8100fca0-444f-42d8-adb9-d052ead73742, userTaskName=Task Name, userTask
 Description=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=8100fca0-444f-42d8-adb9-d052ead73742}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='9e574c1a-067e-4926-811e-471df578d603', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T05:59:47.952687123-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=8100fca0-444f-42d8-adb9-d052ead73742, userTaskName=Task Name, userTaskDescription=null, userTa
 skPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=8100fca0-444f-42d8-adb9-d052ead73742}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='72138693-69ec-4983-8e80-19e54c036196', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T05:59:47.952882935-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=8100fca0-444f-42d8-adb9-d052ead73742, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskRe
 ferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=8100fca0-444f-42d8-adb9-d052ead73742}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='6c6e4ee2-6d3a-49b6-9908-06ce2f6f5c8e', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2025-07-09T05:59:47.953203180-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=8100fca0-444f-42d8-adb9-d052ead73742, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName
 =User Task 1, state=Created, actualOwner=null, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, slaDueDate=null], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=8100fca0-444f-42d8-adb9-d052ead73742}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='abd08fb3-c771-4e48-a3ba-e11dea20742c', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2025-07-09T05:59:47.953791929-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 0
 9 05:59:47 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=8100fca0-444f-42d8-adb9-d052ead73742, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Ready, actualOwner=null, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, slaDueDate=null], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Ready, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=8100fca0-444f-42d8-adb9-d052ead73742}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='361fb80f-6cf8-4fe4-8f85-af596900e0cc', source=http://myhost/TimerPro
 cess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.954099979-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=9eefbc6d-7334-4f62-ab80-fb87e9bab593, data={}], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}}
 ,<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='6e97da85-2ded-4cc3-9541-d89b4bd7e08c', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.954241502-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=0cbe25ec-7a77-49c2-bc0d-d790f345c919, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=45adcefd-d719-4f19-a05f-7dd1c3b355af, data={}], kogitoProcessInstanceId='0cbe25ec-7a77-49c2-bc0d-d790f345c919', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=0cbe25ec-7a77-49c
 2-bc0d-d790f345c919, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceStateDataEvent {specVersion=1.0, id='7ea066f5-3e11-4078-9da2-9c838e529601', source=http://myhost/BusinessRuleTask, type='ProcessInstanceStateDataEvent', time=2025-07-09T05:59:48.021405473-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processType=BPMN, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, businessKey=null, processName=Default Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=1, roles=null, cloudEventId=null ,cloudEventSource=null], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='t
 est', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceVariableDataEvent {specVersion=1.0, id='bdb5ab80-ab76-429a-b670-c9edb848d13e', source=http://myhost/BusinessRuleTask, type='ProcessInstanceVariableDataEvent', time=2025-07-09T05:59:47.699619470-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceVariableEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, nodeContainerDefinitionId=null, nodeContainerInstanceId=null, variableId=person, variableName=person, variableValue=Person{name='john', age=25, adult=true}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRule
 Task', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=0, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='842ec4e4-f870-4073-9ecb-f343a9cd2e5e', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.700443375-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, connectionNodeInstanceId=null, nodeDefinitionId=StartEvent_1, nodeName=Start, nodeType=StartNode, nodeInstanceId=2bf44dc3-e77c-4347-8c6f-863447816576, data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootP
 rocessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='223ba46b-b748-48db-ac78-3769c18db543', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:47.700708149-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:47 EDT 2025, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=BusinessRuleTask_2, nodeName=Business Rule Task, nodeType=RuleSetNode, nodeInstanceId=e94b0bc7-87bb-4800-8a45-d2b261ca34e8, 
 data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceVariableDataEvent {specVersion=1.0, id='7c8d6282-bcd7-4770-9fe0-f988ba6d1c83', source=http://myhost/BusinessRuleTask, type='ProcessInstanceVariableDataEvent', time=2025-07-09T05:59:48.019220826-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceVariableEventBody [eventDate=Wed Jul 09 05:59:48 EDT 2025, eventUser=null, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, nodeContainerDefinitionId=null, nodeContainerInstanceId=null, variableId=person, variableName=pers
 on, variableValue=Person{name='john', age=25, adult=true}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='9890a51c-7193-4cfc-b2e4-989c28f9adf8', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:48.019493072-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:48 EDT 2025, eventUser=null, eventType=1, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, connectionNodeInstanceId=SequenceFlow_1, nodeDe
 finitionId=EndEvent_1, nodeName=End, nodeType=EndNode, nodeInstanceId=dcd0e808-a7af-4515-8377-1de8a2e4e391, data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=1, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='c4e9b016-5b71-4151-8267-18d09739e30e', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:48.019830866-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:48 EDT 2025, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8d
 f4c79c394, connectionNodeInstanceId=null, nodeDefinitionId=EndEvent_1, nodeName=End, nodeType=EndNode, nodeInstanceId=dcd0e808-a7af-4515-8377-1de8a2e4e391, data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='071df3f5-bbf3-4660-8b1b-c02b5f6b37f5', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:48.019977680-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:48 EDT 2025, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=
 1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=BusinessRuleTask_2, nodeName=Business Rule Task, nodeType=RuleSetNode, nodeInstanceId=e94b0bc7-87bb-4800-8a45-d2b261ca34e8, data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='e3c31f10-915f-4000-917b-73fd2ba5012e', source=http://myhost/BusinessRuleTask, type='ProcessInstanceNodeDataEvent', time=2025-07-09T05:59:48.021285231-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 05:59:
 48 EDT 2025, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=StartEvent_1, nodeName=Start, nodeType=StartNode, nodeInstanceId=2bf44dc3-e77c-4347-8c6f-863447816576, data={}], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}},<br/>    ProcessInstanceStateDataEvent {specVersion=1.0, id='4fd7b1f7-6b66-4a16-981f-30ae99084542', source=http://myhost/BusinessRuleTask, type='ProcessInstanceStateDataEvent', time=2025-07-09T05:59:48.019717128-04:00, subject='null', dataContentType='application/json', dataSchema=nu
 ll, data=ProcessInstanceStateEventBody [eventDate=Wed Jul 09 05:59:48 EDT 2025, eventUser=null, eventType=2, processId=BusinessRuleTask, processVersion=1, processType=BPMN, processInstanceId=3675138b-4f98-43dc-9ff6-a8df4c79c394, businessKey=null, processName=Default Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=2, roles=null, cloudEventId=null ,cloudEventSource=null], kogitoProcessInstanceId='3675138b-4f98-43dc-9ff6-a8df4c79c394', kogitoRootProcessInstanceId='null', kogitoProcessId='BusinessRuleTask', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=3675138b-4f98-43dc-9ff6-a8df4c79c394, kogitoprocist=2, kogitoprocversion=1, kogitoprocid=BusinessRuleTask, kogitoaddons=test}}]
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3980/9/testReport/org.kie.kogito.addon.quarkus.messaging.common/QuarkusEventThreadPoolTest/testQuarkusEventThreadPoolMultiThreadLongQueueTest/">org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest</a></summary>
   expected: <10000> but was: <9999>
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192994600


##########
api/kogito-services/src/main/java/org/kie/kogito/services/jobs/impl/InMemoryJobService.java:
##########
@@ -117,17 +103,14 @@ public String rescheduleJob(JobDescription jobDescription) {
 
     protected long calculateDelay(JobDescription description) {
         long delay = Duration.between(ZonedDateTime.now(), description.expirationTime().get()).toMillis();
-        if (delay <= 0) {
-            return 1;
-        }
-        return delay;
+        return delay <= 0 ? 1 : delay;
     }
 
     @Override
     public void close() throws Exception {
         LOGGER.info("closing in memory job service");
-        scheduledJobs.clear();
         scheduledJobs.forEach((k, v) -> v.cancel(true));

Review Comment:
   Clear before forEach is an ominous bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192994600


##########
api/kogito-services/src/main/java/org/kie/kogito/services/jobs/impl/InMemoryJobService.java:
##########
@@ -117,17 +103,14 @@ public String rescheduleJob(JobDescription jobDescription) {
 
     protected long calculateDelay(JobDescription description) {
         long delay = Duration.between(ZonedDateTime.now(), description.expirationTime().get()).toMillis();
-        if (delay <= 0) {
-            return 1;
-        }
-        return delay;
+        return delay <= 0 ? 1 : delay;
     }
 
     @Override
     public void close() throws Exception {
         LOGGER.info("closing in memory job service");
-        scheduledJobs.clear();
         scheduledJobs.forEach((k, v) -> v.cancel(true));

Review Comment:
   Clear before forEach was a  bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#issuecomment-3052869371

   
   **PR job** `#10` was: **UNSTABLE**
   Possible explanation: This should be test failures
   
   
   <details>
   <summary><b>Reproducer</b></summary>
   
   
   
   build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980 --skipParallelCheckout
   
   NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
   
   </details>
   
   
   Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3980/10/display/redirect
   
   **Test results:**
   - PASSED: 3610
   - FAILED: 1
   
   Those are the test failures: 
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3980/10/testReport/org.kie.kogito.codegen.rules/PublishEventBusinessRuleIT/testBusinessRuleProcessStartToEndAbortOfUoW/">org.kie.kogito.codegen.rules.PublishEventBusinessRuleIT.testBusinessRuleProcessStartToEndAbortOfUoW</a></summary>
   <br/>Expecting empty but was: [ProcessInstanceStateDataEvent {specVersion=1.0, id='47d11325-2c01-45f9-832c-f0d4071b1f09', source=http://myhost/TimerProcess, type='ProcessInstanceStateDataEvent', time=2025-07-09T07:24:22.376969210-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processType=BPMN, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, businessKey=null, processName=TimerProcess, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=1, roles=null, cloudEventId=null ,cloudEventSource=null], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoproci
 nstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='6848b29e-571a-4511-a979-5b94f2855c5c', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T07:24:22.369003805-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, connectionNodeInstanceId=null, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=3e1f6fab-4c27-4afe-99c8-0392d8faad48, data={}], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootPro
 cessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='c12612af-e63f-400c-902f-34e05879f5a9', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T07:24:22.369784445-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=7e7495ed-5bbf-4ad0-95a9-1d34873c9a8e, data={}], kogitoProcessInstanceId='a570e9
 7c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='28ecbe70-bc29-4f43-9f96-f76dda6c1e4f', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T07:24:22.370630035-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=UserTask_1, nodeName=User Task 1, nodeType=Huma
 nTaskNode, nodeInstanceId=b95495b9-a548-4e80-b5b2-337b1ba6a354, data={}], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='208c786b-9215-457b-82e3-426a0b3953c3', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T07:24:22.371720494-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=e486a902-17ac-4826-9c6c-0aedd67346b1, userTaskName=Task Name, userTaskDescription=n
 ull, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=e486a902-17ac-4826-9c6c-0aedd67346b1}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='8d57ec86-bfa6-4acd-83e6-52f6798b8384', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T07:24:22.372128557-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=e486a902-17ac-4826-9c6c-0aedd67346b1, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1,
  userTaskReferenceName=User Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=e486a902-17ac-4826-9c6c-0aedd67346b1}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='c7c52e5f-3dfd-49a5-9544-4c29a4b77fd0', source=/process/null, type='UserTaskInstanceStateDataEvent', time=2025-07-09T07:24:22.372654309-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=e486a902-17ac-4826-9c6c-0aedd67346b1, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=U
 ser Task 1, state=Created, actualOwner=null, processInstanceId=null, slaDueDate=null], kogitoProcessInstanceId='null', kogitoRootProcessInstanceId='null', kogitoProcessId='null', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoprocist=null, kogitoaddons=test, kogitousertaskiid=e486a902-17ac-4826-9c6c-0aedd67346b1}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='930978f6-5626-474a-b0b8-bfa017e7b994', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2025-07-09T07:24:22.373616745-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=e486a902-17ac-4826-9c6c-0aedd67346b1, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1,
  state=Created, actualOwner=null, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, slaDueDate=null], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Created, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=e486a902-17ac-4826-9c6c-0aedd67346b1}},<br/>    UserTaskInstanceStateDataEvent {specVersion=1.0, id='920a5f8c-4900-41d1-92d4-fc01a8a398b3', source=http://myhost/TimerProcess, type='UserTaskInstanceStateDataEvent', time=2025-07-09T07:24:22.375553756-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=UserTaskInstanceStateEventBody [eventDate=Wed Jul 09 07:24:22 ED
 T 2025, eventUser=null, userTaskDefinitionId=UserTask_1, userTaskInstanceId=e486a902-17ac-4826-9c6c-0aedd67346b1, userTaskName=Task Name, userTaskDescription=null, userTaskPriority=1, userTaskReferenceName=User Task 1, state=Ready, actualOwner=null, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, slaDueDate=null], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitousertaskist=Ready, kogitoprocrefid=User Task 1, kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test, kogitousertaskiid=e486a902-17ac-4826-9c6c-0aedd67346b1}},<br/>    ProcessInstanceNodeDataEvent {specVersion=1.0, id='2ce9ffb0-c80f-4a12-a75f-a924f74acee3', source=http://myhost/TimerProcess, type='P
 rocessInstanceNodeDataEvent', time=2025-07-09T07:24:22.376378382-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=7e7495ed-5bbf-4ad0-95a9-1d34873c9a8e, data={}], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f177b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}},<br/>    Pro
 cessInstanceNodeDataEvent {specVersion=1.0, id='7d4b8fbf-8d23-4c37-a82e-21741ec420a4', source=http://myhost/TimerProcess, type='ProcessInstanceNodeDataEvent', time=2025-07-09T07:24:22.376687867-04:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceNodeEventBody [eventDate=Wed Jul 09 07:24:22 EDT 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=a570e97c-0401-49a7-a990-8f2f177b31bb, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=3e1f6fab-4c27-4afe-99c8-0392d8faad48, data={}], kogitoProcessInstanceId='a570e97c-0401-49a7-a990-8f2f177b31bb', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=a570e97c-0401-49a7-a990-8f2f17
 7b31bb, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}}]
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192994600


##########
api/kogito-services/src/main/java/org/kie/kogito/services/jobs/impl/InMemoryJobService.java:
##########
@@ -117,17 +103,14 @@ public String rescheduleJob(JobDescription jobDescription) {
 
     protected long calculateDelay(JobDescription description) {
         long delay = Duration.between(ZonedDateTime.now(), description.expirationTime().get()).toMillis();
-        if (delay <= 0) {
-            return 1;
-        }
-        return delay;
+        return delay <= 0 ? 1 : delay;
     }
 
     @Override
     public void close() throws Exception {
         LOGGER.info("closing in memory job service");
-        scheduledJobs.clear();
         scheduledJobs.forEach((k, v) -> v.cancel(true));

Review Comment:
   Clear before forEach is a bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [Fix #3979] Fix InMemoryJobService handling in StaticWorkflowApplication [incubator-kie-kogito-runtimes]

Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3980:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3980#discussion_r2192996667


##########
api/kogito-services/src/main/java/org/kie/kogito/services/jobs/impl/StaticJobService.java:
##########
@@ -20,12 +20,11 @@
 
 public class StaticJobService {
 
-    private static InMemoryJobService INSTANCE;
+    private static class InstanceHolder {
+        private static InMemoryJobService INSTANCE = new InMemoryJobService();
+    }
 
     public static InMemoryJobService staticJobService() {
-        if (INSTANCE == null) {

Review Comment:
   This might cause double initilization of the static intance when multi threading



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org