You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Davide Giannella (JIRA)" <ji...@apache.org> on 2017/07/24 13:17:07 UTC
[jira] [Closed] (OAK-6376) Race condition in the
CompositeNodeStore#merge
[ https://issues.apache.org/jira/browse/OAK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davide Giannella closed OAK-6376.
---------------------------------
Bulk close for 1.7.4
> Race condition in the CompositeNodeStore#merge
> ----------------------------------------------
>
> Key: OAK-6376
> URL: https://issues.apache.org/jira/browse/OAK-6376
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: composite
> Reporter: Tomek Rękawek
> Assignee: Tomek Rękawek
> Fix For: 1.8, 1.7.4
>
>
> Following line in the CompositeNodeStore#merge() is prone for race condition:
> {code}
> NodeState processed = commitHook.processCommit(getRoot(), rebase(nodeBuilder), info);
> {code}
> We should compare the rebase() results with the getRoot() method, but with the nodeBuilder.getBaseState(). Otherwise, any changes in the root between getRoot() and rebase() invocations will lead to processing external changes in the commit hook.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)