You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2009/05/25 00:27:32 UTC
svn commit: r778245 - in /xerces/java/trunk/src/org/apache/xerces:
dom/DeepNodeListImpl.java dom/DocumentImpl.java
impl/xs/traversers/XSDAbstractTraverser.java parsers/AbstractSAXParser.java
util/XMLAttributesImpl.java xinclude/XIncludeHandler.java
Author: mrglavas
Date: Sun May 24 22:27:32 2009
New Revision: 778245
URL: http://svn.apache.org/viewvc?rev=778245&view=rev
Log:
Minor performance improvement. String.length() == 0 tends to be slightly faster than String.equals("").
Modified:
xerces/java/trunk/src/org/apache/xerces/dom/DeepNodeListImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/DocumentImpl.java
xerces/java/trunk/src/org/apache/xerces/impl/xs/traversers/XSDAbstractTraverser.java
xerces/java/trunk/src/org/apache/xerces/parsers/AbstractSAXParser.java
xerces/java/trunk/src/org/apache/xerces/util/XMLAttributesImpl.java
xerces/java/trunk/src/org/apache/xerces/xinclude/XIncludeHandler.java
Modified: xerces/java/trunk/src/org/apache/xerces/dom/DeepNodeListImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/DeepNodeListImpl.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/DeepNodeListImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/DeepNodeListImpl.java Sun May 24 22:27:32 2009
@@ -101,7 +101,7 @@
public DeepNodeListImpl(NodeImpl rootNode,
String nsName, String tagName) {
this(rootNode, tagName);
- this.nsName = (nsName != null && !nsName.equals("")) ? nsName : null;
+ this.nsName = (nsName != null && nsName.length() != 0) ? nsName : null;
enableNS = true;
}
Modified: xerces/java/trunk/src/org/apache/xerces/dom/DocumentImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/DocumentImpl.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/DocumentImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/DocumentImpl.java Sun May 24 22:27:32 2009
@@ -543,7 +543,7 @@
{
// We can't dispatch to blank type-name, and of course we need
// a listener to dispatch to
- if (type == null || type.equals("") || listener == null)
+ if (type == null || type.length() == 0 || listener == null)
return;
// Each listener may be registered only once per type per phase.
@@ -586,7 +586,7 @@
boolean useCapture)
{
// If this couldn't be a valid listener registration, ignore request
- if (type == null || type.equals("") || listener == null)
+ if (type == null || type.length() == 0 || listener == null)
return;
Vector nodeListeners = getEventListeners(node);
if (nodeListeners == null)
@@ -687,7 +687,7 @@
// VALIDATE -- must have been initialized at least once, must have
// a non-null non-blank name.
- if(!evt.initialized || evt.type == null || evt.type.equals("")) {
+ if (!evt.initialized || evt.type == null || evt.type.length() == 0) {
String msg = DOMMessageFormatter.formatMessage(DOMMessageFormatter.DOM_DOMAIN, "UNSPECIFIED_EVENT_TYPE_ERR", null);
throw new EventException(EventException.UNSPECIFIED_EVENT_TYPE_ERR, msg);
}
Modified: xerces/java/trunk/src/org/apache/xerces/impl/xs/traversers/XSDAbstractTraverser.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/impl/xs/traversers/XSDAbstractTraverser.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/impl/xs/traversers/XSDAbstractTraverser.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/impl/xs/traversers/XSDAbstractTraverser.java Sun May 24 22:27:32 2009
@@ -159,7 +159,7 @@
localpart = rawname.substring(colonIndex+1);
}
String uri = schemaDoc.fNamespaceSupport.getURI(fSymbolTable.addSymbol(prefix));
- if (!annotationDecl.getAttributeNS(uri, localpart).equals("")) {
+ if (annotationDecl.getAttributeNS(uri, localpart).length() != 0) {
i++; // skip the next value, too
continue;
}
Modified: xerces/java/trunk/src/org/apache/xerces/parsers/AbstractSAXParser.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/parsers/AbstractSAXParser.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/parsers/AbstractSAXParser.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/parsers/AbstractSAXParser.java Sun May 24 22:27:32 2009
@@ -2289,8 +2289,8 @@
}
public String getType(String uri, String localName) {
- return uri.equals("") ? fAttributes.getType(null, localName) :
- fAttributes.getType(uri, localName);
+ return uri.length() == 0 ? fAttributes.getType(null, localName) :
+ fAttributes.getType(uri, localName);
}
public String getValue(int i) {
@@ -2302,8 +2302,8 @@
}
public String getValue(String uri, String localName) {
- return uri.equals("") ? fAttributes.getValue(null, localName) :
- fAttributes.getValue(uri, localName);
+ return uri.length() == 0 ? fAttributes.getValue(null, localName) :
+ fAttributes.getValue(uri, localName);
}
public int getIndex(String qName) {
@@ -2311,8 +2311,8 @@
}
public int getIndex(String uri, String localPart) {
- return uri.equals("") ? fAttributes.getIndex(null, localPart) :
- fAttributes.getIndex(uri, localPart);
+ return uri.length() == 0 ? fAttributes.getIndex(null, localPart) :
+ fAttributes.getIndex(uri, localPart);
}
// Attributes2 methods
Modified: xerces/java/trunk/src/org/apache/xerces/util/XMLAttributesImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/util/XMLAttributesImpl.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/util/XMLAttributesImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/util/XMLAttributesImpl.java Sun May 24 22:27:32 2009
@@ -175,7 +175,7 @@
int index;
if (fLength < SIZE_LIMIT) {
- index = name.uri != null && !name.uri.equals("")
+ index = name.uri != null && name.uri.length() != 0
? getIndexFast(name.uri, name.localpart)
: getIndexFast(name.rawname);
Modified: xerces/java/trunk/src/org/apache/xerces/xinclude/XIncludeHandler.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/xinclude/XIncludeHandler.java?rev=778245&r1=778244&r2=778245&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/xinclude/XIncludeHandler.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/xinclude/XIncludeHandler.java Sun May 24 22:27:32 2009
@@ -2136,7 +2136,7 @@
return relativeURI;
}
else {
- if (relativeURI.equals("")) {
+ if (relativeURI.length() == 0) {
relativeURI = fCurrentBaseURI.getLiteralSystemId();
}
@@ -2145,7 +2145,7 @@
fParentRelativeURI =
fParentXIncludeHandler.getRelativeBaseURI();
}
- if (fParentRelativeURI.equals("")) {
+ if (fParentRelativeURI.length() == 0) {
return relativeURI;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org