Re: [PR] ARTEMIS-5364 clean up scripts & profiles [activemq-artemis]

["brusdev (via GitHub)" <gi...@apache.org>]

brusdev commented on code in PR #5578:
URL: https://github.com/apache/activemq-artemis/pull/5578#discussion_r2164428109


##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -212,10 +211,7 @@ public void testWindows() throws Exception {
                                    "set ARTEMIS_HOME=", null, // no expected value for this, we will check on the output
                                    "set ARTEMIS_INSTANCE=", "\"" + windows + "\"",
                                    "set ARTEMIS_DATA_DIR=", "\"" + windowsData + "\"",
-                                   "set ARTEMIS_ETC_DIR=", "\"" + windowsETC + "\"",
-                                   "set ARTEMIS_OOME_DUMP=", "\"" + windows + "/log/oom_dump.hprof\"",

Review Comment:
   Is the check for `ARTEMIS_OOME_DUMP` removed on purpose for windowsETC + "/artemis.profile.cmd"?



##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -930,12 +930,10 @@ protected static void addScriptFilters(Map<String, String> filters,
       // so that's just to make a distinction
       filters.put("@artemis.instance@", path(directory));
       filters.put("${artemis.instance.uri}", directory.toURI().toString());
-      filters.put("${artemis.instance.uri.windows}", directory.toURI().toString().replaceAll("%", "%%"));

Review Comment:
   Is `artemis.instance.uri` still used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact