[jira] [Commented] (CXF-6216) No output sanitizing in FormattedServiceListWriter

["Mike Noordermeer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286435#comment-15286435 ] 

Mike Noordermeer commented on CXF-6216:
---------------------------------------

A security scan pointed out an actual XSS issue with this. By including a matrix parameter it is possible to include arbitrary code in the page. Something like this is enough to include an onmouseover (with javascript):

{{GET /api/;"onmouseover='nwsh(9102)'bad=" HTTP/1.1}}

Note that you should send the " unescaped (browsers usually escape this, try a telnet session).

Example conversation, using CXF 3.1.5, Tomcat 7.0.69, Java 8u92: https://gist.github.com/MikeN123/f35a0d63ff8484b123ff76d14ad8e1c9

> No output sanitizing in FormattedServiceListWriter 
> ---------------------------------------------------
>
>                 Key: CXF-6216
>                 URL: https://issues.apache.org/jira/browse/CXF-6216
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.1
>            Reporter: Donald Kwakkel
>
> No output sanitizing is done, which makes the code vulnerable for injection. I do not have a specific use case, but it is good habit to do. Maybe you can use the OWASP Sanitizer: https://www.owasp.org/index.php/OWASP_Java_HTML_Sanitizer_Project
> One example from the file: 
>         writer.write("<span class=\"field\">Endpoint address:</span> " + "<span class=\"value\">"
>                      + absoluteURL + "</span>");



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)